fix: Update FollowingStep component to use ref for currentGuidePositions #1489
Conversation
|
Skipping CI for Draft Pull Request. |
…n FollowingStep component
…improve clarity and error management
…al, AssetLibraryModal, and SpriteBasicConfig
… loading logic in StepPlayer
| @@ -84,9 +86,19 @@ function setFilterControls() { | |||
| filter.setFilter('backdrop', props.step.isBackdropControl, props.step.backdrops) | |||
| } | |||
|
|
|||
| const isStepProcessing = ref(false) | |||
…er logic in FollowingStep component
…management in StepPlayer component
|
|
||
| return Object.keys(props.step.taggingHandler).map((path) => { | ||
| const type = props.step.taggingHandler[path] | ||
| const { getElement } = useTag() |
There was a problem hiding this comment.
useTag() 尽量拿出去，放在 setup script 下顶层做
| findAndSetupElement() | ||
| }, 500) | ||
| }, | ||
| { immediate: true, deep: true } |
There was a problem hiding this comment.
这里应该不需要 deep: true；如果需要，大概率是什么地方实现得有问题
|
|
||
| setFilterControls() | ||
|
|
||
| // Wait for modal to be shown |
There was a problem hiding this comment.
跟 #1489 (comment) 这里提到的问题一样，这里不应该需要去搞个 timeout 去特地等某个组件“渲染完成”
另外这里很奇怪的是，为什么给 stepType.value 赋值这件事情也要推迟到 modal 渲染完成后呢？
There was a problem hiding this comment.
其实现在的场景会需要这个等待组件渲染，因为modal渲染的有点慢，如果不加的话Mask计算的高亮就会小一圈
There was a problem hiding this comment.
因为modal渲染的有点慢，如果不加的话Mask计算的高亮就会小一圈
这个是 Mask 的 bug，应该由 Mask 去解决，Mask 应该确保目标元素发生了动态的尺寸变化后还能正确地高亮之
There was a problem hiding this comment.
#1388 你可以看下这个 PR 以及相关的讨论，能正确地随着目标元素的动态变更去调整自己是 Mask 本来就预期做到的
There was a problem hiding this comment.
OK，这里最好是把这个已知问题注释记一下，等 Mask 修复好了这里再把注释干掉
| @@ -86,19 +115,18 @@ function setFilterControls() { | |||
| filter.setFilter('backdrop', props.step.isBackdropControl, props.step.backdrops) | |||
| } | |||
|
|
|||
| const isStepProcessing = ref(false) | |||
| const isProcessing = ref(false) | |||
There was a problem hiding this comment.
我还是没看懂，这个 isProcessing 是干嘛的
|
This PR has been deployed to the preview environment. You can explore it using the preview URL. Warning Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team. |
| stepType.value = step.type | ||
|
|
||
| await nextTick() |
There was a problem hiding this comment.
这个 await nextTick() 也很迷啊，在它之后看上去没有别的行为了，那它的存在是为了推迟什么呢？
No description provided.