Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secret config store #708

Merged
merged 1 commit into from
Mar 15, 2018
Merged

Conversation

dominikschulz
Copy link
Member

This PR adds an encrypted config store for credentials needed to access backends (e.g. Consul or Vault Tokens).

@dominikschulz dominikschulz added the feature Enhancements and new features label Mar 12, 2018
@dominikschulz dominikschulz self-assigned this Mar 12, 2018
@codecov
Copy link

codecov bot commented Mar 13, 2018

Codecov Report

Merging #708 into master will decrease coverage by 0.87%.
The diff coverage is 41.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #708      +/-   ##
==========================================
- Coverage   65.49%   64.62%   -0.87%     
==========================================
  Files         152      156       +4     
  Lines        8692     8889     +197     
==========================================
+ Hits         5692     5744      +52     
- Misses       2328     2459     +131     
- Partials      672      686      +14
Impacted Files Coverage Δ
app.go 57.14% <ø> (ø) ⬆️
backend/storage.go 100% <ø> (ø) ⬆️
backend/crypto/xc/xc.go 57.5% <0%> (ø) ⬆️
store/root/store.go 45% <0%> (-9.35%) ⬇️
store/root/git.go 0% <0%> (ø) ⬆️
store/sub/init.go 20% <0%> (-1.43%) ⬇️
store/root/gpg.go 0% <0%> (ø) ⬆️
config/io.go 72.73% <100%> (+0.36%) ⬆️
action/action.go 100% <100%> (ø) ⬆️
store/root/mount.go 55.43% <100%> (ø) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8a229e...d5b633f. Read the comment docs.

@dominikschulz dominikschulz changed the title WIP: Add secret config store Add secret config store Mar 15, 2018
@dominikschulz dominikschulz merged commit 1a239b0 into gopasspw:master Mar 15, 2018
@dominikschulz dominikschulz deleted the feature/seccfg branch March 15, 2018 13:00
kpitt pushed a commit to kpitt/gopass that referenced this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Enhancements and new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant