Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Consul K/V storage backend #697

Merged
merged 1 commit into from
Mar 8, 2018

Conversation

dominikschulz
Copy link
Member

Depends on #677

Fixes #672

@dominikschulz dominikschulz added feature Enhancements and new features storage Storage / FS Backends labels Mar 4, 2018
@dominikschulz dominikschulz changed the title WIP: Implement Consul K/V storage backend Implement Consul K/V storage backend Mar 8, 2018
@codecov
Copy link

codecov bot commented Mar 8, 2018

Codecov Report

Merging #697 into master will decrease coverage by 0.03%.
The diff coverage is 68.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #697      +/-   ##
==========================================
- Coverage   64.41%   64.38%   -0.03%     
==========================================
  Files         150      150              
  Lines        8426     8450      +24     
==========================================
+ Hits         5427     5440      +13     
- Misses       2334     2344      +10     
- Partials      665      666       +1
Impacted Files Coverage Δ
backend/store.go 100% <ø> (ø) ⬆️
backend/strings.go 80.65% <ø> (ø) ⬆️
backend/url.go 59.21% <0%> (-4.17%) ⬇️
store/sub/store.go 63.13% <76.19%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0113f0...e210cb5. Read the comment docs.

@dominikschulz dominikschulz merged commit 57514d0 into gopasspw:master Mar 8, 2018
@dominikschulz dominikschulz deleted the feature/issue-672 branch March 8, 2018 11:13
kpitt pushed a commit to kpitt/gopass that referenced this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Enhancements and new features storage Storage / FS Backends
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant