Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement zsh completion generator #565

Merged
merged 1 commit into from
Dec 25, 2017

Conversation

dominikschulz
Copy link
Member

Fixes #557

@dominikschulz dominikschulz added packaging ux User experience / User Interface related labels Dec 25, 2017
@dominikschulz dominikschulz added this to the 1.6.7 - Bugfix release milestone Dec 25, 2017
@dominikschulz dominikschulz self-assigned this Dec 25, 2017
@dominikschulz dominikschulz force-pushed the feature/issue-557 branch 2 times, most recently from 2b14fc5 to 2c7a6ae Compare December 25, 2017 14:52
@dominikschulz dominikschulz changed the title WIP: Implement zsh completion generator Implement zsh completion generator Dec 25, 2017
@codecov
Copy link

codecov bot commented Dec 25, 2017

Codecov Report

Merging #565 into master will increase coverage by 0.2%.
The diff coverage is 36.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #565     +/-   ##
=========================================
+ Coverage   21.52%   21.73%   +0.2%     
=========================================
  Files         108      110      +2     
  Lines        6393     6507    +114     
=========================================
+ Hits         1376     1414     +38     
- Misses       4742     4807     +65     
- Partials      275      286     +11
Impacted Files Coverage Δ
main.go 5.9% <0%> (-0.12%) ⬇️
utils/completion/zsh/completion.go 27.27% <27.27%> (ø)
utils/completion/fish/completion.go 42.37% <42.37%> (ø)
action/completion.go 83.33% <63.63%> (-10.22%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01edf0f...9ab51ba. Read the comment docs.

@dominikschulz dominikschulz merged commit 23bb1b8 into gopasspw:master Dec 25, 2017
@dominikschulz dominikschulz deleted the feature/issue-557 branch December 25, 2017 15:44
kpitt pushed a commit to kpitt/gopass that referenced this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux User experience / User Interface related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant