-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pledge(2) support for OpenBSD #469
Conversation
Pledge (OpenBSD only) is a way to restrict the operations an application can make use of on OpenBSD. Applications declare their intent by specifying the system calls they will use, after which point, any use outside of the pledge'd calls will result in the kernel killing the process. More info on pledge can be found here: http://man.openbsd.org/pledge
Note that this might disable the version check web call in Otherwise, a great idea IMHO, we might want to add |
(oh well, libseccomp bindings invoke CGo: that would probably open a whole new can of worms, forget what I just said...) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I couldn't verify this on OpenBSD, yet.
CGo would only be an option if we find a way to cross-compile our releases. CGo for Linux-only files would probably be possible, but restrict building releases to Linux. If you still want Seccomp it would probably be best to move this to another issue. |
@qbit If I understand the pledge documentation correctly this breaks the version check as @falschparker82 noticed. IMHO we're missing the I'll leave it to your discretion if this is OK or not. |
As pointed out in gopasspw#469, the pledging breaks the version check. My testing "worked" because of the HEAD check.. Since we typically disable remote version checks in OpenBSD anyway (doing an update would break the package otherwise), we might as well disable it here.
As pointed out in #469, the pledging breaks the version check. My testing "worked" because of the HEAD check.. Since we typically disable remote version checks in OpenBSD anyway (doing an update would break the package otherwise), we might as well disable it here.
Pledge (OpenBSD only) is a way to restrict the operations an application can make use of on OpenBSD. Applications declare their intent by specifying the system calls they will use, after which point, any use outside of the pledge'd calls will result in the kernel killing the process. More info on pledge can be found here: http://man.openbsd.org/pledge
As pointed out in gopasspw#469, the pledging breaks the version check. My testing "worked" because of the HEAD check.. Since we typically disable remote version checks in OpenBSD anyway (doing an update would break the package otherwise), we might as well disable it here.
Pledge (OpenBSD only) is a way to restrict the operations an
application can make use of on OpenBSD. Applications declare
their intent by specifying the system calls they will use,
after which point, any use outside of the pledge'd calls will
result in the kernel killing the process.
More info on pledge can be found here: http://man.openbsd.org/pledge