Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add config option to toggle colored output #414

Merged
merged 1 commit into from
Oct 24, 2017
Merged

add config option to toggle colored output #414

merged 1 commit into from
Oct 24, 2017

Conversation

qbit
Copy link
Contributor

@qbit qbit commented Oct 22, 2017

make tests passes this time. Previously I had only run make test and make test-integration, because apparently s is invisible to me :D

@dominikschulz dominikschulz self-requested a review October 22, 2017 16:57
@dominikschulz
Copy link
Member

We had this option in the past. We've discussed the removal in #206 and removed it in #213.
Do you have a good use case over using GOPASS_NOCOLOR?

@qbit
Copy link
Contributor Author

qbit commented Oct 22, 2017 •
edited
Loading

Having two locations (env var and config file) that dictate the behaviour of gopass seems to increase the cognitive overhead to me (even more so because there is only one config option that is usable as an env var). IMO, the ideal situation would be to have all or none of the config options specified via env var.

@dominikschulz
Copy link
Member

Right now we need to keep the envvar for nocolor to support the integration tests, but we may consider removing it in the future.

dominikschulz
dominikschulz approved these changes Oct 24, 2017
View reviewed changes
Copy link
Member

@dominikschulz dominikschulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dominikschulz dominikschulz merged commit db6492e into gopasspw:master Oct 24, 2017
dominikschulz pushed a commit that referenced this pull request Oct 24, 2017
Merge branch 'master' of github.com:justwatchcom/gopass
02000de 
* 'master' of github.com:justwatchcom/gopass:
  add config option to toggle colored output (#414)
  GPG related fixes (#419)
kpitt pushed a commit to kpitt/gopass that referenced this pull request Jul 21, 2022
@qbit @dominikschulz
add config option to toggle colored output (gopasspw#414)
8ab5b4e
kpitt pushed a commit to kpitt/gopass that referenced this pull request Jul 21, 2022
Merge branch 'master' of github.com:justwatchcom/gopass
895645e 
* 'master' of github.com:justwatchcom/gopass:
  add config option to toggle colored output (gopasspw#414)
  GPG related fixes (gopasspw#419)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikschulz dominikschulz dominikschulz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qbit @dominikschulz