Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gopass recipients add/remove selection wizard #359

Merged
merged 1 commit into from
Oct 5, 2017
Merged

gopass recipients add/remove selection wizard #359

merged 1 commit into from
Oct 5, 2017

Conversation

dominikschulz
Copy link
Member

Fixes #351

@dominikschulz dominikschulz added feature Enhancements and new features ux User experience / User Interface related labels Sep 28, 2017
@dominikschulz dominikschulz added this to the 1.5.0 - Wizards milestone Sep 28, 2017
metalmatze
metalmatze suggested changes Oct 2, 2017
View reviewed changes
Copy link
Contributor

@metalmatze metalmatze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really sure if I'm doing something wrong here. But I get this:

./gopass recipients add
gpg: error reading key: Invalid user ID
Failed to list public key '0xB1C7DF661ABB2C1A - Matthias Loibl <mail@matthiasloibl.com>': exit status 2

Error: no key added

Otherwise I like the feature and pretty good stuff should be possible with termwiz, I guess ☺️

@dominikschulz
Copy link
Member Author

dominikschulz commented Oct 3, 2017 •
edited
Loading

Not sure why you "requested changes".
Obviously there is an issue with your private key, but without any further info no one but you will be able to reproduce it.

@dominikschulz
Copy link
Member Author

We just confirmed that this works for us. Just raise an issue if you gather the info to reproduce your problem.

@dominikschulz dominikschulz merged commit 2c065a4 into gopasspw:master Oct 5, 2017
@dominikschulz dominikschulz deleted the feature/issue-351 branch October 5, 2017 12:49
@metalmatze
Copy link
Contributor

Sorry to cause confusion. Not sure what the problem was, but I've not seen it again so far. 👍

kpitt pushed a commit to kpitt/gopass that referenced this pull request Jul 21, 2022
@dominikschulz
gopass recipients add/remove selection wizard (gopasspw#359)
0a74062 
Fixes gopasspw#351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalmatze metalmatze metalmatze requested changes

Assignees
No one assigned
Labels
feature Enhancements and new features ux User experience / User Interface related
Projects
None yet
Milestone
1.5.0 - Wizards
Development

Successfully merging this pull request may close these issues.
2 participants
@dominikschulz @metalmatze