Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add storage.TryAdd and TryCommit methods #2723

Merged
merged 2 commits into from
Nov 25, 2023
Merged

Add storage.TryAdd and TryCommit methods #2723

merged 2 commits into from
Nov 25, 2023

Conversation

dominikschulz
Copy link
Member

@dominikschulz dominikschulz commented Nov 24, 2023 •
edited
Loading

This PR adds new Try methods to the RCS backends. Each of the new methods will attempt to Add, Commit or Push but ignore any non-critical errors.

This simplifies the call sites since they no longer have to have lenghty error handling.

@dominikschulz dominikschulz marked this pull request as ready for review November 25, 2023 16:01
@dominikschulz
Add storage.TryAdd and TryCommit methods
ddfc085 
Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz dominikschulz added the cleanup Code hygiene label Nov 25, 2023
@dominikschulz dominikschulz added this to the 1.15.10 milestone Nov 25, 2023
AnomalRoil
AnomalRoil previously approved these changes Nov 25, 2023
View reviewed changes
Copy link
Member

@AnomalRoil AnomalRoil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside the Linter issues and the Fossil errors and logs, LGTM

internal/backend/storage/fossilfs/fossil.go Outdated Show resolved Hide resolved
internal/backend/storage/fossilfs/fossil.go Outdated Show resolved Hide resolved
@dominikschulz
Fix lint errors and replace Git with Fossil in the Fossil backend.
81202fb 
Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
AnomalRoil
AnomalRoil approved these changes Nov 25, 2023
View reviewed changes
Copy link
Member

@AnomalRoil AnomalRoil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dominikschulz dominikschulz merged commit 8dfd7bd into gopasspw:master Nov 25, 2023
@dominikschulz dominikschulz deleted the fix/try branch November 25, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnomalRoil AnomalRoil AnomalRoil approved these changes

Assignees
No one assigned
Labels
cleanup Code hygiene
Projects
None yet
Milestone
1.15.10
Development

Successfully merging this pull request may close these issues.
2 participants
@dominikschulz @AnomalRoil