Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] Remove leading and trailing slashes from mounts #2698

Merged
merged 3 commits into from
Nov 18, 2023
Merged

[bugfix] Remove leading and trailing slashes from mounts #2698

merged 3 commits into from
Nov 18, 2023

Conversation

dominikschulz
Copy link
Member

Fixes #2669

@dominikschulz
[bugfix] Remove leading and trailing slashes from mounts
30e7f22 
Fixes gopasspw#2669

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz dominikschulz added this to the 1.15.9 milestone Nov 18, 2023
AnomalRoil
AnomalRoil previously approved these changes Nov 18, 2023
View reviewed changes
Copy link
Member

@AnomalRoil AnomalRoil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the test case could have covered leading slashes too, but lgtm

@dominikschulz
Add tests for leading slashes
bf6dabf 
Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz
Copy link
Member Author

There you go :)

AnomalRoil
AnomalRoil previously approved these changes Nov 18, 2023
View reviewed changes
@dominikschulz
Reorder mount alias checks
72d0697 
Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz dominikschulz merged commit 73b880d into gopasspw:master Nov 18, 2023
@dominikschulz dominikschulz deleted the fix/issue-2669-2 branch November 18, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnomalRoil AnomalRoil AnomalRoil left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.15.9
Development

Successfully merging this pull request may close these issues.

Store is undeletable if store name is accidentally ended with /
2 participants
@dominikschulz @AnomalRoil