Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] add/update choco, scoop, winget instructions #2647

Merged
merged 5 commits into from
Sep 9, 2023

Conversation

dpprdan
Copy link
Contributor

@dpprdan dpprdan commented Sep 4, 2023

This adds/updates Windows installation instructions with chocolatey, scoop, and winget.

The scoop and choco manifests do not include the git and gpg4win dependencies, so they have to be installed separately. Should we add those to the README?
There is a choco install gpg4win there already, which is why I added winget install git and winget install gpg4win. The alternative would be to add the dependencies to the manifests so that choco/scoop install gopass would also install the dependencies.

The winget manifest already includes both dependencies, but the winget cli does not support installing those just yet (the next minor version will add this functionality). winget probably needs some more time to properly support dependencies (i.e. I am currently failing at submitting the manifest with dependencies included due to (IMHO) overzealous checks).

BTW is this warning still valid?

**WARNING**: Windows is not yet officially supported. We try to support it in the future. These are steps are only meant to help you setup gopass on Windows so you can provide us with feedback about the current state of our Windows support.

Signed-off-by: Daniel Possenriede <possenriede@gmail.com>
@dpprdan dpprdan force-pushed the docs/winget_install_deps branch from 8fe545c to 7268178 Compare September 5, 2023 08:12
@dominikschulz dominikschulz self-assigned this Sep 6, 2023
docs/setup.md Outdated Show resolved Hide resolved
@AnomalRoil
Copy link
Member

You're right, I think the warning can go, Windows support is there to stay.

Signed-off-by: Daniel Possenriede <possenriede@gmail.com>
@dpprdan
Copy link
Contributor Author

dpprdan commented Sep 7, 2023

I still wonder what the best strategy re the dependencies/backends is (on Windows). gopass installs fine without them and you can also run it without them. age is also an alternative to gpg, but I don't know how well it works in Windows. So I see three options:

  1. do not add dependencies to the manifests, and
    a. just add git and gpg4win them to the installation instructions.
    b. add git, gpg, and, alternatively age (not sure whether it is in any of the package manager repos, though) to the installation instructions.
  2. add git and gpg4win to the manifests so they get automatically installed with gopass (where possible, otherwise 1a - I assume that this should work with choco and scoop)

dominikschulz
dominikschulz previously approved these changes Sep 8, 2023
README.md Outdated Show resolved Hide resolved
Signed-off-by: Daniel Possenriede <possenriede@gmail.com>
Signed-off-by: Daniel Possenriede <possenriede@gmail.com>
Copy link
Member

@dominikschulz dominikschulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dominikschulz dominikschulz merged commit b81d8ba into gopasspw:master Sep 9, 2023
@dpprdan dpprdan deleted the docs/winget_install_deps branch September 10, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants