[Fix] Using the correct env prefix for env settings #2617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
7131785 to
906cc52
Compare
|
We might consider to rename |
|
This change looks good. Thanks for taking care. Let me think about the proposed rename for a bit. |
|
The rename should be fine, but we can do that in another PR. |
AnomalRoil
added a commit
that referenced
this pull request
Nov 2, 2023
…o GOPASS_CONFIG_KEY_i As discussed in #2617, this actually reflects the way GIT_CONFIG works
AnomalRoil
added a commit
that referenced
this pull request
Nov 2, 2023
…o GOPASS_CONFIG_KEY_i As discussed in #2617, this actually reflects the way GIT_CONFIG works Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
AnomalRoil
added a commit
that referenced
this pull request
Nov 2, 2023
…o GOPASS_CONFIG_KEY_i As discussed in #2617, this actually reflects the way GIT_CONFIG works. It also fixes a potential Panic in our codebase when IsSet was called without any Preset config on a non-existing key. Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
dominikschulz
pushed a commit
that referenced
this pull request
Nov 3, 2023
* [CLEANUP] Moving options to the correct config section This adds an easy migration path to our config handling, which should allow us to migrate option names around much more easily in the future. Any system level config or env variables options are not migrated. This also fixes a bug in our test code, where the root mount path was not properly set in our config, because we used "path:" instead of "path=" to set it. Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com> * [DOCUMENTATION] Document legacy options and their migration path This also makes sure that legacy options aren't used in the code anymore using the docs test and its regexp Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com> * [n/a] Removing weird spaces from changelog Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com> * [DOCUMENTATION] Reformatting our Markdown tables properly Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com> * [TESTING] Patching a timezone bug in tests This is a fun one where if your Timezone isn't UTC and you are past midnight but it's not past midnight UTC, the tests would fail because you're not using the right date to validate it. Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com> * [n/a] Fix a typo and use the correct Env variables in the doc about the custom Env variables Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com> * [BREAKING] Custom Env options moved from GOPASS_CONFIG_CONFIG_KEY_i to GOPASS_CONFIG_KEY_i As discussed in #2617, this actually reflects the way GIT_CONFIG works. It also fixes a potential Panic in our codebase when IsSet was called without any Preset config on a non-existing key. Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com> * [CLEANUP] Patching all of the new linter complaints Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com> * [CLEANUP] Use Go1.21 everywhere Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com> * [n/a] Increase our Golangci timeout Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com> * [n/a] code review comment and extra regression test Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com> --------- Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our config options can be set using the
GOPASS_CONFIG__CONFIG_COUNToption followed byGOPASS_CONFIG__CONFIG_KEY_0and same for values, but this seems to be a bug.It should be
GOPASS_CONFIG_CONFIG_KEY_0without 2 underscores according to our documentation.This PR fixes it.