Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set vim options instead of sniffing the config #2343

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

dominikschulz
Copy link
Member

Fixes #2317

RELEASE_NOTES=[ENHANCEMENT] Set vim options instead of sniffing

Signed-off-by: Dominik Schulz dominik.schulz@gauner.org

Fixes gopasspw#2317

RELEASE_NOTES=[ENHANCEMENT] Set vim options instead of sniffing

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz dominikschulz added this to the 1.14.7 milestone Sep 16, 2022
AnomalRoil
AnomalRoil previously approved these changes Sep 20, 2022
internal/editor/editor.go Show resolved Hide resolved
}

path := "/dev/shm/gopass*"
if runtime.GOOS == "darwin" {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does that work on Windows? (Are we even using vim on windows?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea. Someone else would need to test that.

internal/editor/editor.go Show resolved Hide resolved
Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggested method for "Securing Your Editor" still leaks passwords.
2 participants