-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix completion when password name contains quotes #2150
Fix completion when password name contains quotes #2150
Conversation
da82bd7
to
8353b32
Compare
Lgtm, thanks! |
Thanks for the quick review @AnomalRoil!
Not sure why this check fails, any idea? |
You need to add a RELEASE_NOTES tag as explained here, I think: |
8353b32
to
dace13e
Compare
RELEASE_NOTES=[BUGFIX] Fix completion when password name contains quotes. Signed-off-by: Patrick Decat <pdecat@gmail.com>
dace13e
to
e6d332c
Compare
Thanks, should have looked there 🤦♂️ Added the RELEASE_NOTES tag but CommitCheck is still complaining: Your PR description is not valid. Should I have used a template of some sort or link to an issue for the PR description? |
I'm not sure what's wrong. We can merge that nonetheless, so don't worry. Btw, I've just tested your code locally and it doesn't seem to work like I expected it. Does it display with a " in the completion output on your side now? |
Ah, I could reproduce it, the default completion for bash was calling my system-wide install of gopass:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
RELEASE_NOTES=[BUGFIX] Fix completion when password name contains quotes. Signed-off-by: Patrick Decat <pdecat@gmail.com>
This PR fixes shell completion when some passwords names contain single or double quotes.
Without this change, completion either returns nothing or inconsistent results depending on the number of quotes passwords matching the requested completion contain.
TODO: