Depending on how the .gpg-ids file was written, we may not match against the string itself. #2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nst the string itself. We may need to do a query to crypto.FindRecipients to get their details to match against when removing. Fix for gopasspw#1964 RELEASE_NOTES=[BUGFIX] Fixes an issue where recipients remove may fail with "recipient not in store" Signed-off-by: Ben Phegan <benphegan@gmail.com>
dominikschulz
requested changes
Mar 2, 2022
internal/store/leaf/recipients.go
Outdated
| // To do this though, we need to ensure that we also do a FindRecipients on the id name from the stored ids. | ||
| recipient_ids, err := s.crypto.FindRecipients(ctx, k) | ||
| if err != nil { | ||
| out.Printf(ctx, "Warning: Failed to get GPG Key Info for %s: %s", k, err) |
There was a problem hiding this comment.
There is out.Warnf. Consider using that for consistent formating.
There was a problem hiding this comment.
Done. I have updated an additional call that was already present and using Printf for consistency.
internal/store/leaf/recipients.go
Outdated
|
|
||
| // If we don't match immediately, we may need to loop through the recipient keys to try and match. | ||
| // To do this though, we need to ensure that we also do a FindRecipients on the id name from the stored ids. | ||
| recipient_ids, err := s.crypto.FindRecipients(ctx, k) |
There was a problem hiding this comment.
Underscores in Go variable names are uncommon. Please use camel case, e.g. recipientIDs.
There was a problem hiding this comment.
Too much Terraform! :) Done.
internal/store/leaf/recipients.go
Outdated
| continue RECIPIENTS | ||
| } | ||
|
|
||
| for _, recipient_id := range recipient_ids { |
There was a problem hiding this comment.
recipientID, please. Or just recipient or maybe id.
RELEASE_NOTES=[BUGFIX] Fixes an issue where recipients remove may fail
with "recipient not in store"
Signed-off-by: Ben Phegan <benphegan@gmail.com>
|
Hey, thanks! Just one quick question, the PR seems to have failed the DCO check for the |
kpitt
pushed a commit
to kpitt/gopass
that referenced
this pull request
Jul 21, 2022
…nst the string itself. (gopasspw#2147) * Depending on how the .gpg-ids file was written, we may not match against the string itself. We may need to do a query to crypto.FindRecipients to get their details to match against when removing. Fix for gopasspw#1964 RELEASE_NOTES=[BUGFIX] Fixes an issue where recipients remove may fail with "recipient not in store" Signed-off-by: Ben Phegan <benphegan@gmail.com> * Fixed variable naming and Printf to Warningf as per PR. RELEASE_NOTES=[BUGFIX] Fixes an issue where recipients remove may fail with "recipient not in store" Signed-off-by: Ben Phegan <benphegan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may need to do a query to crypto.FindRecipients to get their details to match against when removing. Fix for #1964
RELEASE_NOTES=[BUGFIX] Fixes an issue where recipients remove may fail
with "recipient not in store"
Signed-off-by: Ben Phegan benphegan@gmail.com