Fix autoclip-on-generate behavior. #2040
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, secrets would autoclip only when output was being redirected, which is incorrect. Secrets should autoclip when output is not being redirected (i.e. we're on a TTY). RELEASE_NOTES=[BUGFIX] Fixed autoclip when generating secrets. Signed-off-by: Adriano Caloiaro <github@adriano.fyi>
|
I think that was actually already fixed in #2024, no? But you have more tests, so I'd love to still get the extra tests if you could rebase on master and fix the conflict? |
|
I see. I'll go ahead and shut this one down. If anyone wants to grab the extra test and apply it, please feel free. |
|
@AnomalRoil The existing test appears to be nearly identical in coverage to mine: dominikschulz@c53a985#diff-0ed14f4fcc141393a29d562b970e0f3efa80ae0608ed2a3d00ceb37bba8918fd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2023
Previously, secrets would autoclip only when output was being
redirected, which is incorrect. Secrets should autoclip when output is
not being redirected (i.e. we're on a TTY).
RELEASE_NOTES=[BUGFIX] Fixed autoclip when generating secrets.
Signed-off-by: Adriano Caloiaro github@adriano.fyi