[Go 1.18] Introduce type parameters #2034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9e8803f to
49d56d5
Compare
527656e to
ca4b9c4
Compare
AnomalRoil
previously approved these changes
Dec 21, 2021
Comment on lines
+69
to
+77
| bes := make([]V, 0, len(r.backends)) | ||
| for _, be := range r.backends { | ||
| bes = append(bes, be) | ||
| } |
There was a problem hiding this comment.
Looking forward the new maps package in 1.19 for that :)
Comment on lines
+88
to
+95
| if name == "gpg" { | ||
| name = "gpgcli" | ||
| } |
There was a problem hiding this comment.
Why do we have a hardcoded "exception" like that here? Wouldn't it be best to change the name on the backend side?
There was a problem hiding this comment.
yeah, probably. need to clean this up but it's still hardcoded in a bunch of places.
| if be, found := r.backends[key]; found { | ||
| return be, nil | ||
| } | ||
| var zero V |
There was a problem hiding this comment.
Nice one, I'll remember it when I'll play with Generics too.
This commit replaces some overly complex constructs with type parameters. Fixes gopasspw#2030 RELEASE_NOTES=[ENHANCEMENT] Generics Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
ca4b9c4 to
4e73c17
Compare
kpitt
pushed a commit
to kpitt/gopass
that referenced
this pull request
Jul 21, 2022
This commit replaces some overly complex constructs with type parameters. Fixes gopasspw#2030 RELEASE_NOTES=[ENHANCEMENT] Generics Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces some overly complex constructs with type
parameters.
Fixes #2030
RELEASE_NOTES=[ENHANCEMENT] Generics
Signed-off-by: Dominik Schulz dominik.schulz@gauner.org