Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit a warning when untracked files are present in a git store #1972

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

dominikschulz
Copy link
Member

@dominikschulz dominikschulz commented Aug 8, 2021

RELEASE_NOTES=[ENHANCEMENT] Warn on untracked files

Fixes #1962

Signed-off-by: Dominik Schulz dominik.schulz@gauner.org

RELEASE_NOTES=[ENHANCEMENT] Warn on untracked files

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@AnomalRoil AnomalRoil merged commit 687bbc7 into gopasspw:master Aug 13, 2021
@dominikschulz dominikschulz deleted the fix/issue-1962 branch August 14, 2021 20:28
@dominikschulz dominikschulz modified the milestones: 1.13.0, 1.12.8 Aug 28, 2021
@mcnesium
Copy link

So what shall we do when we see this warning? Also, what could have caused the file to become untracked?

@dominikschulz
Copy link
Member Author

A password store is just a regular git repository. Anyone or anything could have created files in there w/o committing them.

As for fixing it: Again, it's just a git repo. Use git to identify and then either commit or remove any offending diffs.

kpitt pushed a commit to kpitt/gopass that referenced this pull request Jul 21, 2022
…spw#1972)

RELEASE_NOTES=[ENHANCEMENT] Warn on untracked files

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gopass sync doesn't notice staged, un-commited changes?
3 participants