Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use /tmp for GIT_SSH_COMMAND on MacOS to avoid path too long errors #1951

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Use /tmp for GIT_SSH_COMMAND on MacOS to avoid path too long errors #1951

merged 1 commit into from
Jul 1, 2021

Conversation

dominikschulz
Copy link
Member

Fixes #1896

RELEASE_NOTES=[BUGFIX] Use /tmp for GIT_SSH_COMMAND on Mac

Signed-off-by: Dominik Schulz dominik.schulz@gauner.org

@dominikschulz
Use /tmp for GIT_SSH_COMMAND on MacOS to avoid path too long errors
9297935 
Fixes gopasspw#1896

RELEASE_NOTES=[BUGFIX] Use /tmp for GIT_SSH_COMMAND on Mac

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz dominikschulz added the bug Defects label Jul 1, 2021
@dominikschulz dominikschulz added this to the 1.12.7 milestone Jul 1, 2021
@dominikschulz dominikschulz requested a review from AnomalRoil July 1, 2021 09:52
AnomalRoil
AnomalRoil approved these changes Jul 1, 2021
View reviewed changes
Copy link
Member

@AnomalRoil AnomalRoil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember why we needed persistant connections in the first place, but /tmp seems like a global folder that isn't necessarily cleared regularily.

Not sure if that would enable "stealing" of persistent SSH connections by another user possible?

@dominikschulz
Copy link
Member Author

Persistent connections speed up subsequent gopass sync invocations notably.
Many applications use /tmp for their control sockets. If the files are created with sane defaults (i.e. 0700) then we should be good.

The sticky bit should stop attacks trying to replace the control socket.

@dominikschulz dominikschulz merged commit 98acf3e into gopasspw:master Jul 1, 2021
@dominikschulz dominikschulz deleted the fix/issue-1896 branch July 1, 2021 12:40
kpitt pushed a commit to kpitt/gopass that referenced this pull request Jul 21, 2022
@dominikschulz
Use /tmp for GIT_SSH_COMMAND on MacOS to avoid path too long errors (g…
a343325 
…opasspw#1951)

Fixes gopasspw#1896

RELEASE_NOTES=[BUGFIX] Use /tmp for GIT_SSH_COMMAND on Mac

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnomalRoil AnomalRoil AnomalRoil approved these changes

Assignees
No one assigned
Labels
bug Defects
Projects
None yet
Milestone
1.12.7
Development

Successfully merging this pull request may close these issues.

Cant sync: ControlPath too long for Unix domain socket
2 participants
@dominikschulz @AnomalRoil