Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fish completion for otp subcommand #1932

Merged
merged 1 commit into from
May 29, 2021

Conversation

valer-cara
Copy link
Contributor

@valer-cara valer-cara commented May 25, 2021

Fill in entries on gopass otp <TAB> in fish shell, just like gopass show <TAB>.

Funny testing this on Arch. Fish checks and loads /usr/share/fish/vendor_completions.d/gopass.fish which cleared my local mods. Took a while to figure out why i had to double source this file. Alas, once this is merged it'll make it's way into the Arch vendor files.

@dominikschulz
Copy link
Member

Sorry, but this is a generated file.
We'll need to fix the generator.

@valer-cara
Copy link
Contributor Author

@dominikschulz - I've fixed the generator and also ran make completion which put my initial change in place

Copy link
Member

@dominikschulz dominikschulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dominikschulz dominikschulz merged commit 4cec3ef into gopasspw:master May 29, 2021
kpitt pushed a commit to kpitt/gopass that referenced this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants