Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding release Github Action #1728

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Adding release Github Action #1728

merged 1 commit into from
Jan 19, 2021

Conversation

AnomalRoil
Copy link
Member

This is a basic action added through the Github interface to see if goreleaser works out of the box.

@AnomalRoil AnomalRoil self-assigned this Jan 19, 2021
@codecov-io
Copy link

codecov-io commented Jan 19, 2021

Codecov Report

Merging #1728 (bf22722) into master (a1f5496) will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1728      +/-   ##
==========================================
+ Coverage   58.06%   58.22%   +0.16%     
==========================================
  Files         189      189              
  Lines        9080     9172      +92     
==========================================
+ Hits         5272     5340      +68     
- Misses       3210     3230      +20     
- Partials      598      602       +4     
Impacted Files Coverage Δ
internal/store/leaf/crypto.go 32.86% <0.00%> (-4.85%) ⬇️
internal/action/commands.go 100.00% <0.00%> (ø)
internal/backend/crypto.go 71.43% <0.00%> (+0.60%) ⬆️
internal/action/init.go 56.30% <0.00%> (+2.28%) ⬆️
internal/action/clone.go 59.72% <0.00%> (+2.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1f5496...bf22722. Read the comment docs.

@AnomalRoil AnomalRoil marked this pull request as ready for review January 19, 2021 11:23
@AnomalRoil
Copy link
Member Author

This should trigger when we push to a tag v*, I'll try that next to see how it works: I didn't understand what's happening with the releases once they are produced yet 😆

Signing should be super easy to add once we've figured out how we want to handle the GPG key part:
https://github.com/goreleaser/goreleaser-action#signing

RELEASE_NOTES=[TESTING] Adding DI to Github Actions

Signed-off-by: Yolan Romailler <yolan@romailler.ch>
@AnomalRoil AnomalRoil changed the title Trying Github actions Adding release Github Action Jan 19, 2021
Copy link
Member

@dominikschulz dominikschulz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dominikschulz dominikschulz merged commit 337357e into master Jan 19, 2021
@dominikschulz dominikschulz deleted the workflow1 branch January 19, 2021 13:43
kpitt pushed a commit to kpitt/gopass that referenced this pull request Jul 21, 2022
RELEASE_NOTES=[TESTING] Adding DI to Github Actions

Signed-off-by: Yolan Romailler <yolan@romailler.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants