Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional pinentry unescaping #1710

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

dominikschulz
Copy link
Member

Fixes #1621

RELEASE_NOTES=[ENHANCEMENT] Add optional pinentry unescaping

Signed-off-by: Dominik Schulz dominik.schulz@gauner.org

@dominikschulz dominikschulz added this to the 1.11.1 milestone Jan 14, 2021
AnomalRoil
AnomalRoil previously approved these changes Jan 14, 2021
Copy link
Member

@AnomalRoil AnomalRoil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Were you able to test this on a Yubikey or do you want me to do so before merging?

pkg/pinentry/pinentry.go Outdated Show resolved Hide resolved
pkg/pinentry/pinentry.go Show resolved Hide resolved
Fixes gopasspw#1621

RELEASE_NOTES=[ENHANCEMENT] Add optional pinentry unescaping

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz
Copy link
Member Author

No, I haven't been able to test this with a YubiKey setup. Could you do that, please?

@AnomalRoil
Copy link
Member

I'll take a look this afternoon with a Yubikey.

Copy link
Member

@AnomalRoil AnomalRoil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with a Yubikey and yubikey-agent, simply had to enable
pinentry.Unescape = true in yubikey-agent and it worked.

But I had to update my systemd and ended up doing a full distro upgrade for this test, that was unexpected xD

@AnomalRoil AnomalRoil merged commit f5a3a0c into gopasspw:master Jan 15, 2021
kpitt pushed a commit to kpitt/gopass that referenced this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gopass/pkg/pinentry: pinentry escapes '%' as '%25' and gopass does not unescape this
2 participants