Use 32 byte salt by default #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
89441c2 to
c76facd
Compare
Codecov Report
@@ Coverage Diff @@
## master #1690 +/- ##
==========================================
- Coverage 57.31% 57.19% -0.13%
==========================================
Files 205 205
Lines 9806 9770 -36
==========================================
- Hits 5620 5587 -33
+ Misses 3526 3521 -5
- Partials 660 662 +2
Continue to review full report at Codecov.
|
AnomalRoil
previously approved these changes
Jan 6, 2021
c76facd to
e24143c
Compare
This changes the salted hash funcs for the template feature to use 32 salts by default and accept a parameter to choose the desired salt length. Fixes gopasspw#1688 RELEASE_NOTES=[ENHANCEMENT] Use 32 byte salt by default Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
e24143c to
c018eb7
Compare
kpitt
pushed a commit
to kpitt/gopass
that referenced
this pull request
Jul 21, 2022
This changes the salted hash funcs for the template feature to use 32 salts by default and accept a parameter to choose the desired salt length. Fixes gopasspw#1688 RELEASE_NOTES=[ENHANCEMENT] Use 32 byte salt by default Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the salted hash funcs for the template feature to
use 32 salts by default and accept a parameter to choose the
desired salt length.
Fixes #1688
Signed-off-by: Dominik Schulz dominik.schulz@gauner.org