gopass-git-credentials: rename to git-credential-gopass

[sgn]

With this rename, we can use "gopass" as a git-credential,
no need to have the hackery of invoke another shell.

[codecov-io]

Codecov Report

Merging #1670 (73f14ee) into master (af9c95d) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #1670   +/-   ##
=======================================
  Coverage   57.64%   57.64%           
=======================================
  Files         204      204           
  Lines        9854     9854           
=======================================
  Hits         5680     5680           
  Misses       3503     3503           
  Partials      671      671           

Impacted Files	Coverage Δ
cmd/git-credential-gopass/git-credential.go	62.59% <0.00%> (ø)
cmd/git-credential-gopass/main.go	0.00% <0.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af9c95d...73f14ee. Read the comment docs.

[dominikschulz]

Doesn't this configure the gopass binary itself as the git credential helper?

[sgn]

On 2020-12-31 12:54:46-0800, Dominik Schulz ***@***.***> wrote: @dominikschulz commented on this pull request. > @@ -243,7 +243,7 @@ func (s *gc) Configure(c *cli.Context) error { if flags == 0 { log.Println("No target given, assuming --global.") } - cmd := exec.CommandContext(ctx, "git", "config", flag, "credential.helper", `"!gopass-git-credentials $@"`) + cmd := exec.CommandContext(ctx, "git", "config", flag, "credential.helper", "gopass") Doesn't this configure the `gopass` binary itself as the git credential helper?

This configure "git-credential-gopass" as the git credential helper. https://git-scm.com/docs/gitcredentials#Documentation/gitcredentials.txt-helper

…

-- Danh

[dominikschulz]

LGTM

[dominikschulz]

Thank you. Please rebase and add RELEASE_NOTES= tags to your commit message(s).