Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails with "no remote" if remote is named other than origin #691

Closed
koiuo opened this issue Mar 2, 2018 · 3 comments
Closed

Fails with "no remote" if remote is named other than origin #691

koiuo opened this issue Mar 2, 2018 · 3 comments
Assignees
Labels
bug Defects

Comments

@koiuo
Copy link

koiuo commented Mar 2, 2018

[~]$ cd .password-store

[~/.password-store]$ git remote
github

[~/.password-store]$ gopass sync
Sync starting ...
[<root>] 
   git pull and push ... Skipped (no remote)
@koiuo koiuo changed the title Fails with no remote if remote is named other than origin Fails with "no remote" if remote is named other than origin Mar 2, 2018
@dominikschulz dominikschulz self-assigned this Mar 3, 2018
@dominikschulz dominikschulz added the bug Defects label Mar 3, 2018
@dominikschulz
Copy link
Member

dominikschulz commented Mar 3, 2018

Correct, this is limitation currently exists.
It should be easy to lift this limitation for the trivial case were only one remote exists.
Not sure about a heuristic if multiple exist.

dominikschulz added a commit to dominikschulz/gopass that referenced this issue Mar 3, 2018
@koiuo
Copy link
Author

koiuo commented Mar 3, 2018

I'm not aware of how do you interact with git, sorry if my question is off. But shouldn't it be possible if current branch was a tracking branch? In git CLI for example it's enough to type just git push in this case, even if multiple remotes exist.

@dominikschulz
Copy link
Member

Yes, that is correct. I also thought #692 might be overengineered right after submitting it, but if you haven't properly setup your git remotes a simple git push may fail. We want to help our users with that case. Unfortunately simply assuming defaults (origin/master) makes some use cases fail while the lookup logic in #692 duplicates the logic git does by itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defects
Projects
None yet
Development

No branches or pull requests

2 participants