Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal issues from #446 have resurfaced because of #562 #587

Closed
qbit opened this issue Jan 1, 2018 · 5 comments
Closed

Terminal issues from #446 have resurfaced because of #562 #587

qbit opened this issue Jan 1, 2018 · 5 comments
Assignees
@dominikschulz
Labels
bug Defects
Milestone
1.6.8 - Bugfix re...

Comments

@qbit
Copy link
Contributor

qbit commented Jan 1, 2018 •
edited
Loading

Looks like gocui uses termbox-go under the hood. As described in #446 #445, there is an issue with this lib on BSDs.

I looked briefly at switching gocui to use the tcell lib, seems tcell is missing some mouse handling stuff..
@dominikschulz
Copy link
Member

The problem is that the other lib breaks MacOS and I'd rather break OpenBSD than Mac (sorry, but due to the number of users on each system ...)

@qbit
Copy link
Contributor Author

qbit commented Jan 1, 2018

Makes sense.. Maybe we can have it pick a lib depending on +build directives? Or maybe it's worth adding a feature that completely disables the UI?

dominikschulz added a commit to dominikschulz/gopass that referenced this issue Jan 2, 2018
@dominikschulz
Fall back to termwiz on openbsd
abc48bc 
Fixes gopasspw#587
@dominikschulz
Copy link
Member

Actually I saw this coming and wanted to include some option before releasing 1.6.7 but forgot about it.
We'll release a hotfix as soon as you confirm it works on OpenBSD and later on can look for a proper solution.

This was referenced Jan 2, 2018
Merged
Closed
@dominikschulz dominikschulz self-assigned this Jan 2, 2018
@dominikschulz dominikschulz added this to the 1.6.8 - Bugfix release milestone Jan 2, 2018
dominikschulz added a commit that referenced this issue Jan 2, 2018
@dominikschulz
Fall back to termwiz on openbsd (#588)
69b7552 
Fixes #587
@qbit
Copy link
Contributor Author

qbit commented Jan 2, 2018

Can confirm, #588 fixes the terminal issues on OpenBSD!

@dominikschulz
Copy link
Member

Thanks for checking! Will try to schedule another bugfix release ASAP.

kpitt pushed a commit to kpitt/gopass that referenced this issue Jul 21, 2022
@dominikschulz
Fall back to termwiz on openbsd (gopasspw#588)
3c42428 
Fixes gopasspw#587
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dominikschulz dominikschulz

Labels
bug Defects
Projects
None yet
Milestone
1.6.8 - Bugfix release
Development

No branches or pull requests
2 participants
@qbit @dominikschulz