Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gopass -c <search> doesn't copy secret to clipboard #531

Closed
moritzheiber opened this issue Dec 18, 2017 · 4 comments
Closed

gopass -c <search> doesn't copy secret to clipboard #531

moritzheiber opened this issue Dec 18, 2017 · 4 comments
Assignees
Labels
feature Enhancements and new features ux User experience / User Interface related

Comments

@moritzheiber
Copy link

It used to be that gopass was capable of copying whatever you were searching for to the clipboard afterwards, i.e.:

$ gopass -c something
Entry 'something' not found. Starting search...
<search-model-selection>
<selection-confirmation>
Copied i/was/looking/for/something to clipboard. Will clear in 45 seconds.
$

Now the -c switch doesn't seem to have any effect anymore, rather it outputs the secret directly to the console and exits:

$ gopass -c something
Entry 'something' not found. Starting search...
<search-model-selection>
<selection-confirmation>
i/was/looking/for/something
this_is_secret
$

Has this changed recently? Or is it intended behavior?

@dominikschulz dominikschulz self-assigned this Dec 18, 2017
@dominikschulz
Copy link
Member

If you run gopass -c something and there is no exact match you should see an interative search dialog which prompts you to select a secret.

On the bottom there should be an info line which explains the available operations:
<↑/↓> to change the selection, <→> to show, <←> to copy, <s> to sync, <ESC> to quit.

If you hit enter or press → the secret will be shown. If you press ← the secret will be copied to the clipboard (not the primary selection, if using X11).

Is this the use case you're talking about? In that case I'm not able to reproduce.

@dominikschulz dominikschulz added the bug Defects label Dec 18, 2017
@moritzheiber
Copy link
Author

I see, then I'd say it's a little misleading, as the -c implies that you want you password copied to your clipboard, or wouldn't it?

I understand the UI approach, but the UX is a little differentiating. I would also be in favor of keeping the switches' behavior intend intact, but that's just me.

@dominikschulz
Copy link
Member

I think it would make sense to make the default behaviour (i.e. when hiting enter) match the command line switches. That's what you're suggesting, isn't it?

@dominikschulz dominikschulz added feature Enhancements and new features ux User experience / User Interface related and removed bug Defects labels Dec 18, 2017
@moritzheiber
Copy link
Author

Yes, I think that’d be an appropriate solution :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Enhancements and new features ux User experience / User Interface related
Projects
None yet
Development

No branches or pull requests

2 participants