Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't edit secret: failed to run editor.. #478

Closed
d3vr opened this issue Nov 26, 2017 · 2 comments
Closed

Can't edit secret: failed to run editor.. #478

d3vr opened this issue Nov 26, 2017 · 2 comments
Assignees
Labels

Comments

@d3vr
Copy link

d3vr commented Nov 26, 2017

When I try to edit a secret I get this error, each time with a different file name:

Error: failed to invoke editor: failed to run editor with /dev/shm/gopass-edit179424118/secret file

I'm running Arch Linux/Manjaro with the latest version: gopass 1.6.1 (c4e1803 built from gopass-git in the AUR) and go 1.9.2 linux amd64

I tried looking for similar issues here and googling the error, neither of which helped.

Thanks

@d3vr d3vr changed the title Can't edit secret error Can't edit secret: failed to run editor.. Nov 26, 2017
@d3vr
Copy link
Author

d3vr commented Nov 26, 2017

I found the issue: the $EDITOR variable was not set which was causing the problem.

It does say in the docs however, that if the $EDITOR variable is not set, vim will be used by default. That didn't work for me.

I did some investigating:
action/edit_linux.go is returning editor in case the $EDITOR variable is not set, and after some searching I found that @dominikschulz said:

On Linux the user should always get his favourite editor because we check $EDITOR and fall back to editor which should be as symlink to the chosen/default editor.

This is not mentioned in the docs, wouldn't it be more practical/better if vim was actually used by default?

@dominikschulz dominikschulz self-assigned this Nov 27, 2017
dominikschulz pushed a commit to dominikschulz/gopass that referenced this issue Nov 27, 2017
dominikschulz added a commit that referenced this issue Nov 27, 2017
@dominikschulz
Copy link
Member

Thank you very much for reporting this. Should be fixed by #479. Please report back if that doesn't help.

kpitt pushed a commit to kpitt/gopass that referenced this issue Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants