Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML support broken #398

Closed
laedanrex opened this issue Oct 16, 2017 · 2 comments
Closed

YAML support broken #398

laedanrex opened this issue Oct 16, 2017 · 2 comments
Assignees

Comments

@laedanrex
Copy link

Some of my secret are YAML documents :

---
key1: value1
key2: value2 

I've upgrade my gopass version from 1.3.2 to 1.4.1 and the access to a value inside a YAML file gives me an error :
gopass path/to/my/secret key1
1.3.2 returned : value1
1.4.1 returned : Error: failed to retrieve key 'key1' from 'path/to/my/secret': no YAML document marker found

I've tried to change my secret into a YAML file but nothing changed
gopass mv path/to/my/secret path/to/my/secret.yaml

Still got the error

Has the YAML support changed ?

@dominikschulz
Copy link
Member

dominikschulz commented Oct 16, 2017

Yes, indeed. There has been a breaking change wrt. document separators.
We'll try to reproduce and consider if we can support this case better.

@dominikschulz dominikschulz added the bug Defects label Oct 16, 2017
@dominikschulz dominikschulz self-assigned this Oct 16, 2017
@dominikschulz dominikschulz added this to the 1.5.0 - Wizards milestone Oct 16, 2017
dominikschulz pushed a commit to dominikschulz/gopass that referenced this issue Oct 16, 2017
@dominikschulz
Copy link
Member

The problem is that the first line of the secret is empty. Some time ago we started to require YAML document markers in the body of the secret (i.e. not on the first line).

I've just pushed a workaround that should fix your issue.

@dominikschulz dominikschulz added bug/confirmed and removed bug Defects labels Oct 16, 2017
kpitt pushed a commit to kpitt/gopass that referenced this issue Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants