Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gitconfig] Decoding of values with separators is broken #2479

Closed
dominikschulz opened this issue Dec 18, 2022 · 0 comments · Fixed by #2482
Closed

[gitconfig] Decoding of values with separators is broken #2479

dominikschulz opened this issue Dec 18, 2022 · 0 comments · Fixed by #2482
Assignees
@dominikschulz
Milestone
1.15.2

Comments

@dominikschulz
Copy link
Member

Given a config like this:

[core]
	sshCommand = ssh -oControlMaster=auto -oControlPersist=600 -oControlPath=/tmp/.ssh-%C

A Get("core.sshCommand") yields ssh -oControlMaster instead of ssh -oControlMaster=auto -oControlPersist=600 -oControlPath=/tmp/.ssh-%C.
@dominikschulz dominikschulz self-assigned this Dec 18, 2022
@dominikschulz dominikschulz added this to the 1.15.2 milestone Dec 18, 2022
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Dec 18, 2022
@dominikschulz
[gitconfig] Fix splitting of Key-Value pairs
c12788f 
Previously we were ignoring anything after the second equal sign.
This was invalid.

Fixes gopasspw#2479

RELEASE_NOTES=[BUGFIX] [gitconfig] Properly parse Key-Value pairs with
multiple equal signs.

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz dominikschulz mentioned this issue Dec 18, 2022
Merged
dominikschulz added a commit that referenced this issue Dec 18, 2022
@dominikschulz
[gitconfig] Fix splitting of Key-Value pairs (#2482)
0658d53 
Previously we were ignoring anything after the second equal sign.
This was invalid.

Fixes #2479

RELEASE_NOTES=[BUGFIX] [gitconfig] Properly parse Key-Value pairs with
multiple equal signs.

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dominikschulz dominikschulz

Labels
None yet
Projects
None yet
Milestone
1.15.2
Development

Successfully merging a pull request may close this issue.

[gitconfig] Fix splitting of Key-Value pairs dominikschulz/gopass
1 participant
@dominikschulz