Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite KV secrets to retain input data as much as possible #2431

Closed
dominikschulz opened this issue Nov 27, 2022 · 0 comments · Fixed by #2433
Closed

Rewrite KV secrets to retain input data as much as possible #2431

dominikschulz opened this issue Nov 27, 2022 · 0 comments · Fixed by #2433
Assignees
@dominikschulz

Comments

@dominikschulz
Copy link
Member

Similar to gitconfig and #2430 we should also retain pretty much all details in secrets while still supporting key value operations, if possible.
@dominikschulz dominikschulz self-assigned this Nov 27, 2022
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Nov 27, 2022
@dominikschulz
Maintain secret structure when parsing
7620ba7 
This commit introduces a new KV secret type ("AKV") that fully maintains
the secret format when parsing. As such it obsoletes the old KV and
Plain formats and the need for the core.parsing option.

Fixes gopasspw#2431

RELEASE_NOTES=[ENHANCEMENT] Maintain secret structure when parsing

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz dominikschulz mentioned this issue Nov 27, 2022
Merged
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Nov 29, 2022
@dominikschulz
Maintain secret structure when parsing
7729e6b 
This commit introduces a new KV secret type ("AKV") that fully maintains
the secret format when parsing. As such it obsoletes the old KV and
Plain formats and the need for the core.parsing option.

Fixes gopasspw#2431

RELEASE_NOTES=[ENHANCEMENT] Maintain secret structure when parsing

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Nov 30, 2022
@dominikschulz
Maintain secret structure when parsing
68aed63 
This commit introduces a new KV secret type ("AKV") that fully maintains
the secret format when parsing. As such it obsoletes the old KV and
Plain formats and the need for the core.parsing option.

Fixes gopasspw#2431

RELEASE_NOTES=[ENHANCEMENT] Maintain secret structure when parsing

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
dominikschulz added a commit that referenced this issue Dec 1, 2022
@dominikschulz @AnomalRoil
Maintain secret structure when parsing (#2433)
1e7a6b1 
* Maintain secret structure when parsing

This commit introduces a new KV secret type ("AKV") that fully maintains
the secret format when parsing. As such it obsoletes the old KV and
Plain formats and the need for the core.parsing option.

Fixes #2431

RELEASE_NOTES=[ENHANCEMENT] Maintain secret structure when parsing

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>

* Update internal/action/edit.go

Co-authored-by: Yolan Romailler <AnomalRoil@users.noreply.github.com>

* Address review comments

This brings back the noparsing flag since we need this to cover some
corners cases.

RELEASE_NOTES=n/a

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Co-authored-by: Yolan Romailler <AnomalRoil@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dominikschulz dominikschulz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Maintain secret structure when parsing dominikschulz/gopass
1 participant
@dominikschulz