-
-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MacOS Ventura: Failed to remove tempfile #2400
Comments
is sandbox error? |
I haven't tried Ventura, yet. Maybe Apple introduced some new "improvements"? |
I upgraded to Ventura this evening and am experiencing this very same issue. |
I had the same behavior prior to Ventura... and unfortunately upgrading to Ventura doesn't make the error go away. Btw. the mount can then be easily removed by hand! However, editing or creating new secrets is not possible. |
Same error is shown for me after Mac OS update, although |
@fw8 This is very annoying, but the error reported should not prevent anyone from editing or creating secrets. |
I have the same issue with Ventura, gopass 1.14.10 go1.19.3 darwin arm64. Executing with debug output looks like this:
And, as already reported, unmounting manually with e.g. |
I am seeing this issue as well and it appears as if
I was looking at the code to determine what it's doing and it seems like the failure is on the eject: gopass runs a
Note: I have omitted the quiet passed to eject so that stderr is not suppressed. If I umount the device first, then I can eject it.
I was able to work around the issue with the following change: PR It doesn't seem like this change should be necessary, but I'm not sure why the change in behavior. If |
@brianjkinney Thanks a lot for the investigation and the PR. I'll try it out myself on Ventura and if it works as expected we'll merge it. |
I was digging into this a bit more, and from what I can tell the mount command doesn't get captured in the mount information for diskutil. Here I create a disk and then mount it using the mount command which is how gopass handles it.
You can see that diskutil doesn't see the disk as mounted and so when trying to unmount it doesn't appear to do anything.
If instead I use
I believe that prior to Ventura, diskutil had this mount information, and so it definitely seems like a change in behavior after the upgrade. I'm not sure if this works for anyone on Ventura or if it's just some users seeing the failure. My earlier PR was to attempt a umount if it appeared the I'm not trying to rush things, just wanted to provide some possible alternatives that may be cleaner than my original PR. |
Credits to brianjkinney: gopasspw#2400 (comment) Fixes gopasspw#2400 RELEASE_NOTES=[BUGFIX] Fix edit on MacOS Ventura Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Credits to brianjkinney: #2400 (comment) Fixes #2400 RELEASE_NOTES=[BUGFIX] Fix edit on MacOS Ventura Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org> Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Summary
Failed to remove tempfile at /var/folders/37/3fy66clj37d268n32wsfm8400000gn/T/gopass-edit3522339400/secret: failed to unmount /dev/disk5 from /var/folders/37/3fy66clj37d268n32wsfm8400000gn/T/gopass-edit3522339400: exit status 1
Steps To Reproduce
gopass edit
Expected behavior
exit 0
Environment
Additional context
The text was updated successfully, but these errors were encountered: