Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make non-error notifications transient #2358

Closed
Layerex opened this issue Sep 28, 2022 · 1 comment · Fixed by #2364
Closed

Make non-error notifications transient #2358

Layerex opened this issue Sep 28, 2022 · 1 comment · Fixed by #2364
Assignees
@dominikschulz
Labels
feature Enhancements and new features
Milestone
1.14.9

Comments

@Layerex
Copy link
Contributor

Layerex commented Sep 28, 2022 •
edited
Loading

Summary

Make non-error notifications transient, so those don't show up in notification tray.

Screenshot from 2022-09-28 11-32-48

How to send a transient notification:

call := obj.Call("org.freedesktop.Notifications.Notify", 0, "gopass", uint32(0), iconURI(), subj, msg, []string{}, map[string]dbus.Variant{"transient": dbus.MakeVariant(true)}, int32(3000))

Also, I think, for transient nofiications exposition time should be lowered from 5 seconds to 3 (standart transient notifications in GNOME seem to use this value).
@dominikschulz dominikschulz self-assigned this Sep 28, 2022
@dominikschulz dominikschulz added the feature Enhancements and new features label Sep 28, 2022
@dominikschulz dominikschulz added this to the 1.14.9 milestone Sep 28, 2022
@dominikschulz
Copy link
Member

I think we can easily do that. Thank you.

dominikschulz added a commit to dominikschulz/gopass that referenced this issue Sep 28, 2022
@dominikschulz
Make DBus notifications transient
69cb826 
Fixes gopasspw#2358

RELEASE_NOTES=[ENHANCEMENT] Make DBus notifications transient

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz dominikschulz mentioned this issue Sep 28, 2022
Merged
dominikschulz added a commit that referenced this issue Sep 28, 2022
@dominikschulz
Make DBus notifications transient (#2364)
5218945 
Fixes #2358

RELEASE_NOTES=[ENHANCEMENT] Make DBus notifications transient

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dominikschulz dominikschulz

Labels
feature Enhancements and new features
Projects
None yet
Milestone
1.14.9
Development

Successfully merging a pull request may close this issue.

Make DBus notifications transient dominikschulz/gopass
2 participants
@dominikschulz @Layerex