Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling the default gopass create wizard templates #2291

Closed
chaorace opened this issue Jul 29, 2022 · 3 comments · Fixed by #2349
Closed

Allow disabling the default gopass create wizard templates #2291

chaorace opened this issue Jul 29, 2022 · 3 comments · Fixed by #2349
Assignees
Labels
feature Enhancements and new features
Milestone

Comments

@chaorace
Copy link

Currently, the two default wizard templates for gopass create ("Website login" & "PIN Code (numerical)") seem to always load in as options for the wizard.

It would be nice to have a config option to turn this off so that only custom templates appear as options in that wizard menu. I particularly want this because both stock templates are marked "priority: 0", which forces you to use negative priority values in custom templates if you want them to appear first in the list (important if you want to change the default option).

@dominikschulz dominikschulz added the feature Enhancements and new features label Jul 29, 2022
@dominikschulz dominikschulz modified the milestones: 1.14.4, 1.x.x Jul 29, 2022
@dominikschulz
Copy link
Member

Sounds like a valid feature request. But we'll need to figure out how to handle this cleanly.

@dominikschulz
Copy link
Member

Would you prefer to configure this per password store or per user?

@ghost
Copy link

ghost commented Sep 22, 2022

@dominikschulz, in my opinion this issue could be resolved in different way than originally suggested by @chaorace.

How about removing hard-coded templates and automatically adding ".gopass/create/default.yml" with one default template to every new password store? This approach would give the users more control over all templates.

If someone would delete ".gopass/create/default.yml" (without creating any other templates), the program could inform them that no templates are available and ask for username and password that would be stored in root of the password store without any specific prefix.

@dominikschulz dominikschulz self-assigned this Sep 24, 2022
@dominikschulz dominikschulz modified the milestones: 1.x.x, 1.14.8 Sep 24, 2022
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Sep 24, 2022
Fixes gopasspw#2291

RELEASE_NOTES=[ENHANCEMENT] Allow modifying default create templates

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Sep 24, 2022
Fixes gopasspw#2291

RELEASE_NOTES=[ENHANCEMENT] Allow modifying default create templates

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
dominikschulz added a commit that referenced this issue Sep 27, 2022
* Allow modifying and removing default create templates

Fixes #2291

RELEASE_NOTES=[ENHANCEMENT] Allow modifying default create templates

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>

* Commit template changes

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>

* Fix some tests

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Enhancements and new features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants