Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear usage of convert verb for root store #2170

Closed
adrianbroher opened this issue Mar 18, 2022 · 2 comments · Fixed by #2171
Closed

Unclear usage of convert verb for root store #2170

adrianbroher opened this issue Mar 18, 2022 · 2 comments · Fixed by #2171
Assignees
Labels
bug Defects
Milestone

Comments

@adrianbroher
Copy link

Summary

From the existing documentation (docs and --help output) it is not clear how the root store can be converted to another storage or crypto backend.

Steps To Reproduce

Leaving out the --store parameter leads to:

gopass convert --storage gitfs
# ...
2022/03/18 21:35:02 Required flag "store" not set

Setting the --store parameter to an empty string leads to:

$ gopass convert --storage gitfs --store ''
# ...
2022/03/18 21:36:07 unknown backend -1: backend not found

Setting the --store parameter to the string root, / or default leads to the corresponding:

$ gopass convert --storage gitfs --store root
2022/03/18 21:37:40 no such mount point "root"

Expected behavior

When no explicit --store is given I would expect that the convert verb acts on the root store.

Environment

  • OS: Fedora 34
  • OS version: Linux blackbox 5.16.12-100.fc34.x86_64 #1 SMP PREEMPT Wed Mar 2 20:05:34 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
  • gopass Version: gopass 1.13.1 (2022-02-01 00:00:00) go1.16.13 linux amd64
  • Installation method: Copr repo for gopass

Additional context

The root store was (probably) created with:

gopass init --storage fs

but I can't say for sure, as I've set this up years ago. Maybe it was even set up with pass.

The root store is located at ~/.password-store.

@dominikschulz
Copy link
Member

I agree. It should work as you described. I guess I've never tried to convert a root store and missed that in the implementation. I'll give it a try these days and try to fix it.

@dominikschulz dominikschulz self-assigned this Mar 18, 2022
@dominikschulz dominikschulz added the bug Defects label Mar 18, 2022
@dominikschulz dominikschulz added this to the 1.14.1 milestone Mar 18, 2022
@dominikschulz
Copy link
Member

Looking at the code I noticed that the implementation might be incomplete wrt. recipients, need to check that as well.

dominikschulz added a commit to dominikschulz/gopass that referenced this issue Mar 20, 2022
RELEASE_NOTES=[BUGFIX] Improve convert output

Fixes gopasspw#2170

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Mar 21, 2022
RELEASE_NOTES=[BUGFIX] Improve convert output

Fixes gopasspw#2170

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Mar 21, 2022
RELEASE_NOTES=[BUGFIX] Improve convert output

Fixes gopasspw#2170

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Mar 24, 2022
RELEASE_NOTES=[BUGFIX] Improve convert output

Fixes gopasspw#2170

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Mar 24, 2022
RELEASE_NOTES=[BUGFIX] Improve convert output

Fixes gopasspw#2170

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Mar 24, 2022
RELEASE_NOTES=[BUGFIX] Improve convert output

Fixes gopasspw#2170

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Mar 24, 2022
RELEASE_NOTES=[BUGFIX] Improve convert output

Fixes gopasspw#2170

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
dominikschulz added a commit that referenced this issue Mar 24, 2022
RELEASE_NOTES=[BUGFIX] Improve convert output

Fixes #2170

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
kpitt pushed a commit to kpitt/gopass that referenced this issue Jul 21, 2022
RELEASE_NOTES=[BUGFIX] Improve convert output

Fixes gopasspw#2170

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Defects
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants