Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error messages when completing show command on zsh #2005

Closed
avorima opened this issue Oct 8, 2021 · 4 comments
Closed

Error messages when completing show command on zsh #2005

avorima opened this issue Oct 8, 2021 · 4 comments
Milestone

Comments

@avorima
Copy link
Contributor

avorima commented Oct 8, 2021

Summary

Tab completion for the show command on zsh outputs the following error messages:

_describe:compdescribe:124: invalid argument: subcommands
_describe:compdescribe:129: no parsed state

This happens when:

  • no character matches an existing secret or store
  • more than 1 character matches an existing secret or store

The completion still works though.

Steps To Reproduce

$ gopass show secret<Tab>

Expected behavior

No error messages.

Environment

@dominikschulz
Copy link
Member

I'm afraid I don't know much about shell completion and don't use zsh myself. Maybe someone else is able to help.

@ez-pzz
Copy link

ez-pzz commented Nov 21, 2021

The same for lots of subcommands, e.g. gopass clone

❯ gopass clone
_arguments:comparguments:325: invalid option definition: --crypto[Select crypto backend [age gpgcli plain]]
_arguments:comparguments:325: invalid option definition: --crypto[Select crypto backend [age gpgcli plain]]
_arguments:comparguments:325: invalid option definition: --crypto[Select crypto backend [age gpgcli plain]]

It looks like the syntax of _arguments is incorrect

@AnomalRoil
Copy link
Member

AnomalRoil commented Nov 25, 2021

Should be solved by something similar to #2044, I guess.

@AnomalRoil AnomalRoil added this to the 1.13.1 milestone Nov 25, 2021
@dominikschulz dominikschulz modified the milestones: 1.14.0, 1.x.x Jan 17, 2022
rockorager added a commit to rockorager/gopass that referenced this issue Apr 29, 2022
Fix various errors in zsh completions.
- Escape square brackets
- Don't print '_describe...'' if there are no subcommands

RELEASE_NOTES=[BUGFIX] fix errors in zsh completions

Signed-off-by: Tim Culverhouse <tim@timculverhouse.com>
rockorager added a commit to rockorager/gopass that referenced this issue Apr 30, 2022
Fix various errors in zsh completions.
- Escape square brackets
- Don't print '_describe...'' if there are no subcommands

RELEASE_NOTES=[BUGFIX] fix errors in zsh completions

Signed-off-by: Tim Culverhouse <tim@timculverhouse.com>
dominikschulz pushed a commit that referenced this issue May 1, 2022
Fix various errors in zsh completions.
- Escape square brackets
- Don't print '_describe...'' if there are no subcommands

RELEASE_NOTES=[BUGFIX] fix errors in zsh completions

Signed-off-by: Tim Culverhouse <tim@timculverhouse.com>
@avorima
Copy link
Contributor Author

avorima commented May 31, 2022

Version gopass 1.14.2 go1.18.2 linux amd64 does not have any error messages anymore.
I would consider this as fixed.

@avorima avorima closed this as completed May 31, 2022
kpitt pushed a commit to kpitt/gopass that referenced this issue Jul 21, 2022
Fix various errors in zsh completions.
- Escape square brackets
- Don't print '_describe...'' if there are no subcommands

RELEASE_NOTES=[BUGFIX] fix errors in zsh completions

Signed-off-by: Tim Culverhouse <tim@timculverhouse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants