Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate memorable password with --strict #1984

Closed
tomkel opened this issue Aug 28, 2021 · 2 comments · Fixed by #1985
Closed

generate memorable password with --strict #1984

tomkel opened this issue Aug 28, 2021 · 2 comments · Fixed by #1985
Labels
feature Enhancements and new features good-first-issue Good for beginners starting to contribute
Milestone
1.13.0

Comments

@tomkel
Copy link

tomkel commented Aug 28, 2021

Summary

When you gopass generate -g memorable , it produces only lowercase passwords. When combined with --strict , uppercase some letters please?

Steps To Reproduce

gopass generate -g memorable -s --strict test 15

outputs like

alphabet5]soup4,

Expected behavior

a password with a member from each class, including uppercase A-Z, like Alphabet5]soup4,

Environment

  • OS: MacOS
  • OS version: Big Sur 11.5
  • gopass Version: 1.12.8
  • Installation method: brew
@dominikschulz dominikschulz added feature Enhancements and new features good-first-issue Good for beginners starting to contribute labels Sep 2, 2021
@dominikschulz dominikschulz added this to the 1.13.0 milestone Sep 2, 2021
@dominikschulz
Copy link
Member

Sounds good. Maybe someone could contribute this.

@eljpsm
Copy link

eljpsm commented Sep 3, 2021

I would like to work on this and have a solution.

@eljpsm eljpsm mentioned this issue Sep 3, 2021
Merged
AnomalRoil added a commit that referenced this issue Sep 13, 2021
@AnomalRoil
Add capitalized words to memorable passwords (#1985)
9a0336b 
Memorable passwords generated with --strict will now have at least one capitalized word.

Closes #1984

RELEASE_NOTES=[FEATURE] Add capitalized words to memorable passwords

Signed-off-by: Elijah J. Passmore <elijah@elijahjpassmore.com>
Co-authored-by: Yolan Romailler <AnomalRoil@users.noreply.github.com>
kpitt pushed a commit to kpitt/gopass that referenced this issue Jul 21, 2022
@AnomalRoil
Add capitalized words to memorable passwords (gopasspw#1985)
60f30e3 
Memorable passwords generated with --strict will now have at least one capitalized word.

Closes gopasspw#1984

RELEASE_NOTES=[FEATURE] Add capitalized words to memorable passwords

Signed-off-by: Elijah J. Passmore <elijah@elijahjpassmore.com>
Co-authored-by: Yolan Romailler <AnomalRoil@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature Enhancements and new features good-first-issue Good for beginners starting to contribute
Projects
None yet
Milestone
1.13.0
Development

Successfully merging a pull request may close this issue.

Add capitalized words to memorable passwords
3 participants
@tomkel @dominikschulz @eljpsm