-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gopass show -o shows unexpected warning #1961
Comments
Same here! SummaryWhat is the proper approach to store Steps To ReproduceGiven the following environment $ gopass --version
gopass 1.12.8 (2021-08-28 17:36:37) go1.17 darwin amd64
$ gopass-jsonapi --version
gopass-jsonapi version 1.11.1 And I have stored a password $ gopass insert leaf.jp/naruto
Enter password for leaf.jp/naruto: *****
Confirmg password for leaf.jp/naruto: ***** And I also have stored a $ gopass generate --clip --generator memorable leaf.jp/naruto/pin 6 When I show the entry I then receive the following warning $ gopass show -n leaf.jp/naruto
⚠ leaf.jp/naruto is a secret and a folder. Use 'gopass show leaf.jp/naruto' to display the secret and 'gopass list leaf.jp/naruto' to show the content of the folder
Secret: leaf.jp/naruto And when I reveal the password then I receive the same warning $ gopass -o leaf.jp/naruto
⚠ leaf.jp/naruto is a secret and a folder. Use 'gopass show leaf.jp/naruto' to display the secret and 'gopass list leaf.jp/naruto' to show the content of the folder
dattebayo But I can reveal the $ gopass -o leaf.jp/naruto/pin
oro!!! Also, Environment$ uname -a
Darwin Rogerios-MBP 20.6.0 Darwin Kernel Version 20.6.0
$ brew install gopass
$ brew install gopass-jsonapi Additional contextI wasn't able to find any hints on the docs so far. :( Excellent job, btw! I wish I could build something 10% as cool as this! 🤩 |
@roalcantara The proper way to store a "pin" in an entry is to rely on key-values:
Notice the way I use a space to add a key to an entry:
This adds a key "pin" to the entry "leaf.jp/naruto", whereas what you are doing is creating a new entry "leaf.jp/naruto/pin" in the folder "leaf.jp/naruto" while there already is an existing entry "leaf.jp/naruto" as well.
This should works as expected in theory with the bridge and everything. @mcnesium I can still reprodruce the issue with |
RELEASE_NOTES=[BUGFIX] Removing shadowing warning when using -o/--password Fixes #1961 Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
RELEASE_NOTES=[BUGFIX] Removing shadowing warning when using -o/--password Fixing linter too Fixes #1961 Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
RELEASE_NOTES=[BUGFIX] Removing shadowing warning when using -o/--password Fixing linter too Fixes #1961 Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
Thanks for fixing 👍 |
RELEASE_NOTES=[BUGFIX] Removing shadowing warning when using -o/--password Fixing linter too Fixes gopasspw#1961 Signed-off-by: Yolan Romailler <anomalroil@users.noreply.github.com>
gopass still shows warnings, when passing the
-o
flag togopass show
:correct and expected behavior:
imho unnecessary but i guess acceptable behavior:
note: the warning does not appear when using
gopass list
. intended behavior?unexpected behavior:
This gopass is installed from Manjaro community repo:
The text was updated successfully, but these errors were encountered: