Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please allow --strict to be chained with --symbols #1941

Closed
skewballfox opened this issue Jun 7, 2021 · 1 comment · Fixed by #1952
Closed

Please allow --strict to be chained with --symbols #1941

skewballfox opened this issue Jun 7, 2021 · 1 comment · Fixed by #1952
Assignees

Comments

@skewballfox
Copy link

skewballfox commented Jun 7, 2021

Summary

Right now it seems that --strict and --symbols/-s are mutually exclusive, with strict taking priority. These should have the option to be chained together in order to form passwords that have strictly have one member from each char group, symbols included.

The reason these should be chained rather than overriding the behavior of --strict is there are websites which require uppercase letters, lowercase letters, digits, and special characters, just as there are websites that require strict passwords that do not allow special characters(for some stupid reason).

the former currently requires continuously generating passwords with the -s flag until one meets the requirements.

Steps To Reproduce

gopass generate --symbols --strict any.given.website/user@email

Expected behavior

a password with a member from each class a-z,A-Z,0-9 !@#$%^&*()-_+=[{]},<.>/?;:'"\~\|`

Environment

  • OS: fedora 34
  • OS version: 5.12.8-300.fc34.x86_64 Add template feature #1 SMP Fri May 28 15:20:54 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
  • gopass Version: gopass 1.12.5
  • Installation method: copr daftaupe/gopass
@dominikschulz dominikschulz self-assigned this Jun 12, 2021
@dominikschulz
Copy link
Member

Yes, I agree that this should be supported.

dominikschulz added a commit to dominikschulz/gopass that referenced this issue Jul 1, 2021
Fixes gopasspw#1941

RELEASE_NOTES=[BUGFIX] Allow --strict to be chained with --symbols

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
dominikschulz added a commit that referenced this issue Jul 1, 2021
Fixes #1941

RELEASE_NOTES=[BUGFIX] Allow --strict to be chained with --symbols

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
kpitt pushed a commit to kpitt/gopass that referenced this issue Jul 21, 2022
Fixes gopasspw#1941

RELEASE_NOTES=[BUGFIX] Allow --strict to be chained with --symbols

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants