-
-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check the key is capable of encryption / decryption before trying to add to the store #1917
Comments
This is definitely something I'd like to add. Not sure how, but I guess some GPG trickery should be able to give that information. |
@dominikschulz I didn't check how gopass is using gpg, but it is possible to list the keys with |
That's helpful, thank you. We already parse that output but we don't seem to evaluate the key capabilities, yet. |
Signed-off-by: Thomas Mantl <thomas.mantl@redgears.net>
Signed-off-by: Thomas Mantl <thomas.mantl@redgears.net>
Signed-off-by: Thomas Mantl <thomas.mantl@redgears.net>
RELEASE_NOTES=[FEATURE] Add GPG key capabilities and check in key.isUsable Signed-off-by: Thomas Mantl <thomas.mantl@redgears.net>
RELEASE_NOTES=[FEATURE] Add GPG key capabilities and check in key.isUsable Signed-off-by: Thomas Mantl <thomas.mantl@redgears.net>
RELEASE_NOTES=[FEATURE] Add GPG key capabilities and check in key.isUsable Signed-off-by: Thomas Mantl <thomas.mantl@redgears.net>
RELEASE_NOTES=[FEATURE] Add GPG key capabilities and check in key.isUsable Signed-off-by: Thomas Mantl <thomas.mantl@redgears.net>
RELEASE_NOTES=[FEATURE] Add GPG key capabilities and check in key.isUsable Signed-off-by: Thomas Mantl <thomas.mantl@redgears.net>
RELEASE_NOTES=[FEATURE] Add GPG key capabilities and check in key.isUsable Signed-off-by: Thomas Mantl <thomas.mantl@redgears.net>
RELEASE_NOTES=[FEATURE] Add GPG key capabilities and check in key.isUsable Signed-off-by: Thomas Mantl <thomas.mantl@redgears.net>
RELEASE_NOTES=[FEATURE] Add GPG key capabilities and check in key.isUsable Signed-off-by: Thomas Mantl <thomas.mantl@redgears.net>
RELEASE_NOTES=[FEATURE] Add GPG key capabilities and check in key.isUsable Signed-off-by: Thomas Mantl <thomas.mantl@redgears.net>
RELEASE_NOTES=[FEATURE] Add GPG key capabilities and check in key.isUsable Signed-off-by: Thomas Mantl <thomas.mantl@redgears.net>
RELEASE_NOTES=[FEATURE] Add GPG key capabilities and check in key.isUsable Signed-off-by: Thomas Mantl <thomas.mantl@redgears.net>
RELEASE_NOTES=[FEATURE] Add GPG key capabilities and check in key.isUsable Signed-off-by: Thomas Mantl <thomas.mantl@redgears.net>
RELEASE_NOTES=n/a Signed-off-by: Thomas Mantl <thomas.mantl@redgears.net>
RELEASE_NOTES=n/a Signed-off-by: Thomas Mantl <thomas.mantl@redgears.net>
RELEASE_NOTES=n/a Signed-off-by: Thomas Mantl <thomas.mantl@redgears.net>
…ercase) RELEASE_NOTES=[FEATURE] Parse GPG-PrimaryKeyCaps for the entire Key and subKeys Signed-off-by: Thomas Mantl <thomas.mantl@redgears.net>
RELEASE_NOTES=n/a Signed-off-by: Thomas Mantl <thomas.mantl@redgears.net>
* add Caps type to gpg-keys and dummy parse-func * add deactivated keycap flag fixes gopasspw#1917 * make key.IsUsable depend on KeyCaps gopasspw#1917 * gopasspwgh-1917: add key-capabilities in key-tests * gopasspwgh-1917: SubKey Capabilities are also in PrimaryKey Caps (uppercase) * gopasspwgh-1917: provide some meaningful pointers in key error msg RELEASE_NOTES=[FEATURE] only accept keys with "encryption" key capability Signed-off-by: Thomas Mantl <thomas.mantl@redgears.net>
Summary
This is not really a bug, more of an usability issue. When running
gopass recipients add --store <store> <user_id>
for a key that can not do encryption (say, it is a certificate only key), gopass will run and the encryption will just fail on every secret.Steps To Reproduce
Expected behavior
A friendly user message saying the key of
user_id
can not be used because it does not support encryption.Environment
Additional context
Cool project, thanks for it :)
The text was updated successfully, but these errors were encountered: