Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gopass is unable to add subkeys of a key individually #1841

Closed
AnomalRoil opened this issue Mar 15, 2021 · 2 comments · Fixed by #1843
Closed

Gopass is unable to add subkeys of a key individually #1841

AnomalRoil opened this issue Mar 15, 2021 · 2 comments · Fixed by #1843
Milestone

Comments

@AnomalRoil
Copy link
Member

But pass does.

From #909:

Problem 1: can’t use the CLI to add different subkeys as recipients

$ gopass init
[init] Initializing a new password store ...
Please select a private key for encrypting secrets:
[0] gpg - 0x90D516249B728BE6 - Kirill Elagin <kirelagin@gmail.com>
Please enter the number of a key (0-0, [q]uit) [0]: 0
[init] Initializing git repository (gitfs) for kirelagin / ...
Please enter an email address for password store git config []: 
[init] git initialized at /home/kirelagin/.local/lib/gopass
[init] Git Email not set
[init] git configured at /home/kirelagin/.local/lib/gopass
[init] Git initialized
[init] Password store /home/kirelagin/.local/lib/gopass initialized for:
[init]   0x90D516249B728BE6 - Kirill Elagin <kirelagin@gmail.com>

$ gopass recipients add 'FBE0EC61EDA03749197C34D785D128E1B30E1931!'
Do you want to add '0x90D516249B728BE6 - Kirill Elagin <kirelagin@gmail.com>' as a recipient to the store ''? [y/N/q]: y

Error: failed to add recipient 'FBE0EC61EDA03749197C34D785D128E1B30E1931!': Recipient already in store

This is clearly a UX problem, since this is something that should work. Compare to pass:

$ pass init '047A7B2FB0E96F07F9C216DCB3D9F87D907DC8B1!' 'FBE0EC61EDA03749197C34D785D128E1B30E1931!'

and it does exactly what I need. gopass is being smart and, as a result, I could not find any way to init a repo to a specific subkey. Furthermore, since I can’t remove the only recipient, the UI does not allow me to change the recipients list to be made of specific subkeys.

@dominikschulz
Copy link
Member

Yes, I think this should be supported.

dominikschulz added a commit to dominikschulz/gopass that referenced this issue Mar 16, 2021
Fixes gopasspw#1841
Fixes gopasspw#1842

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz
Copy link
Member

I've added a rought draft. If you want have a look and let me know what you think.
But this will require some more work before merging.

@dominikschulz dominikschulz added this to the 1.12.4 milestone Mar 20, 2021
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Mar 20, 2021
Fixes gopasspw#1841
Fixes gopasspw#1842

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz dominikschulz modified the milestones: 1.12.4, 1.12.5 Mar 20, 2021
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Mar 21, 2021
This commit removes some erroneus extra logic that did prevent
us from passing through subkeys.

Fixes gopasspw#1841
Fixes gopasspw#1842

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Mar 21, 2021
This commit removes some erroneus extra logic that did prevent
us from passing through subkeys.

Fixes gopasspw#1841
Fixes gopasspw#1842

RELEASE_NOTES=[BUGFIX] Allow subkeys

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
dominikschulz added a commit that referenced this issue Mar 21, 2021
This commit removes some erroneus extra logic that did prevent
us from passing through subkeys.

Fixes #1841
Fixes #1842

RELEASE_NOTES=[BUGFIX] Allow subkeys

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
kpitt pushed a commit to kpitt/gopass that referenced this issue Jul 21, 2022
This commit removes some erroneus extra logic that did prevent
us from passing through subkeys.

Fixes gopasspw#1841
Fixes gopasspw#1842

RELEASE_NOTES=[BUGFIX] Allow subkeys

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants