Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fscopy and fsmove are not shown in the help #1831

Closed
pdecat opened this issue Mar 11, 2021 · 4 comments · Fixed by #2444
Closed

fscopy and fsmove are not shown in the help #1831

pdecat opened this issue Mar 11, 2021 · 4 comments · Fixed by #2444
Assignees
@dominikschulz
Labels
documentation ux User experience / User Interface related
Milestone
1.15.1

Comments

@pdecat
Copy link
Contributor

pdecat commented Mar 11, 2021 •
edited
Loading

Summary

The fscopy and fsmove subcommands are not shown in the command line help.
I've seen the warning about these commands being moving targets: https://github.com/gopasspw/gopass/blame/v1.12.1/docs/features.md#L309
Is this intentional?

Steps To Reproduce

gopass help

Expected behavior

gopass help should show the fscopy and fsmove commands.

Environment

  • OS: Ubuntu 20.10
  • OS version: Linux myhost 5.8.0-44-generic #50-Ubuntu SMP Tue Feb 9 06:29:41 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
  • gopass Version: gopass 1.12.1-git+HEAD go1.16 linux amd64
  • Installation method: from source

Additional context

N/A
@dominikschulz
Copy link
Member

For the time being this is intentional.

We have a few commands that were added without a solid plan and where we're not sure if or how we want to support them going forward.

So I thought the least disruptive way to discourage their use would be to hide them.

Feel free to make an argument to remove them or make a case to keep them. In the latter case I'd kindly ask for some help with polishing them.

@pdecat
Copy link
Contributor Author

pdecat commented Mar 11, 2021

Please keep them 🙏

My use case with fscopy is to securely store some configuration files containing sensitive information, keystores and private keys.

@dominikschulz
Copy link
Member

At this point there are no plans to remove them.
But before I unhide them we'll need a better "story" (use case, docs, maybe tests) around them.

@AnomalRoil AnomalRoil added documentation ux User experience / User Interface related labels Mar 12, 2021
@dominikschulz dominikschulz changed the title fscopy and fsmove are not shown in the help fscopy and fsmove are not shown in the help Mar 25, 2021
@bozerkins
Copy link

Here's what currently available on how to use those commands
https://github.com/gopasspw/gopass/blob/master/docs/features.md#support-for-binary-content

@nrdxp nrdxp mentioned this issue Apr 27, 2022
Open
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Dec 4, 2022
@dominikschulz
Unhide fscopy and fsmove
563dc7a 
Fixes gopasspw#1831

RELEASE_NOTES=[CLEANUP] Unhide fscopy and fsmove

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz dominikschulz mentioned this issue Dec 4, 2022
Merged
@dominikschulz dominikschulz self-assigned this Dec 4, 2022
@dominikschulz dominikschulz added this to the 1.15.1 milestone Dec 4, 2022
dominikschulz added a commit that referenced this issue Dec 4, 2022
@dominikschulz
Unhide fscopy and fsmove (#2444)
80c2110 
Fixes #1831

RELEASE_NOTES=[CLEANUP] Unhide fscopy and fsmove

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dominikschulz dominikschulz

Labels
documentation ux User experience / User Interface related
Projects
None yet
Milestone
1.15.1
Development

Successfully merging a pull request may close this issue.

Unhide fscopy and fsmove dominikschulz/gopass
4 participants
@pdecat @dominikschulz @bozerkins @AnomalRoil