Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow aborting when presented a list of options #1800

Closed
puck opened this issue Feb 16, 2021 · 1 comment · Fixed by #1805
Closed

Allow aborting when presented a list of options #1800

puck opened this issue Feb 16, 2021 · 1 comment · Fixed by #1805
Assignees
Labels
ux User experience / User Interface related
Milestone

Comments

@puck
Copy link

puck commented Feb 16, 2021

Summary

When a numbered list is presenedt to allow selecting one of the available options there is no way to abort the command, other than killing the gopass process. Control-c doesn't affect gopass (although it does appear to be passed to gpg once an option is selected).

Steps To Reproduce

From your list of secrets, pick a substring that would match more than one secret.

gopass show $(substring)

Attempt to abort.

You could also use any other command that presents a list, for example gopass recipients add

Expected behavior

I would expect that control-c would abort gopass, and it would be nice to present an option ('q'?) to abort.

Environment

  • OS: Debian Sid
  • OS version: Linux dirk 5.10.0-2-amd64 Add template feature #1 SMP Debian 5.10.9-1 (2021-01-20) x86_64 GNU/Linux
  • gopass Version: 1.11.0+89ad7410443fd56b390c79c3d9f78d307224acd8 (89ad741) go1.14.2 linux amd64
  • Installation method: Downloaded .deb and dpkg -i.
@puck puck changed the title Allow aborting when present a list of options Allow aborting when presented a list of options Feb 16, 2021
@dominikschulz
Copy link
Member

Hmm, certainly it's an UX issue to some extent.
Using 'q' does work in most cases, but maybe not always. Also we currently don't give a hint that that's an option.

Using ctrl+c is actually supposed to work. But it might not be evaluated until the current input is processed.

So yes, I get your point. Would be nice to improve that.

We should immedeately quit we crtl+c is pressed and we should support aborting with 'q' in every selection.

@dominikschulz dominikschulz added the ux User experience / User Interface related label Feb 17, 2021
@dominikschulz dominikschulz added this to the 1.x.x milestone Feb 17, 2021
@dominikschulz dominikschulz self-assigned this Feb 20, 2021
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Feb 20, 2021
Fixes gopasspw#1800

RELEASE_NOTES=[BUGFIX] Honor Ctrl+C

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
dominikschulz added a commit to dominikschulz/gopass that referenced this issue Feb 20, 2021
Fixes gopasspw#1800

RELEASE_NOTES=[BUGFIX] Honor Ctrl+C

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
@dominikschulz dominikschulz modified the milestones: 1.x.x, 1.12.2 Feb 20, 2021
AnomalRoil pushed a commit that referenced this issue Feb 22, 2021
Fixes #1800

RELEASE_NOTES=[BUGFIX] Honor Ctrl+C while waiting for user input

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
kpitt pushed a commit to kpitt/gopass that referenced this issue Jul 21, 2022
Fixes gopasspw#1800

RELEASE_NOTES=[BUGFIX] Honor Ctrl+C while waiting for user input

Signed-off-by: Dominik Schulz <dominik.schulz@gauner.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ux User experience / User Interface related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants