[chore] use the same version of golangci-lint

gopasspw · Sep 25, 2024 · 222c01a · 222c01a
1 parent 1eb3850
commit 222c01a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/.github/workflows/golangci-lint.yml b/.github/workflows/golangci-lint.yml
@@ -43,5 +43,9 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@aaa42aa0628b4ae2578232a66b541047968fac86 # v6.1.0
         with:
-          version: v1.59.1 # we have a list of linters in our .golangci.yml config file
+          # Note: there are 2 different version of golangci-lint used inside the project.
+          # https://github.com/gopasspw/gopass/blob/master/.github/workflows/build.yml#L65
+          # https://github.com/gopasspw/gopass/blob/master/.github/workflows/golangci-lint.yml#L46
+          # https://github.com/gopasspw/gopass/blob/master/Makefile#L136
+          version: v1.61.0 # we have a list of linters in our .golangci.yml config file
           only-new-issues: true
diff --git a/Makefile b/Makefile
@@ -131,6 +131,10 @@ crosscompile:
 codequality:
 	@echo ">> CODE QUALITY"
 
+	# Note: there are 2 different version of golangci-lint used inside the project.
+	# https://github.com/gopasspw/gopass/blob/master/.github/workflows/build.yml#L65
+	# https://github.com/gopasspw/gopass/blob/master/.github/workflows/golangci-lint.yml#L46
+	# https://github.com/gopasspw/gopass/blob/master/Makefile#L136
 	@echo -n "     GOLANGCI-LINT "
 	@which golangci-lint > /dev/null; if [ $$? -ne 0 ]; then \
 		$(GO) install github.com/golangci/golangci-lint/cmd/golangci-lint@latest; \