Fix command to start gopass JSON API listener in gopass v1.12.0+ #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -10,6 +10,6 @@ fi | |||
| export PATH="$PATH:/usr/local/bin" # required on MacOS/brew | |||
| export GPG_TTY="$(tty)" | |||
|
|
|||
| gopass jsonapi listen | |||
| ./gopass-jsonapi listen | |||
There was a problem hiding this comment.
I don't think this will work everywhere. I'm not sure where this script is executed, but normally gopass-jsonapi should be installed in the $PATH.
There was a problem hiding this comment.
Doesn't this script get generated? When is this file even used?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In gopass v1.12.0, the binaries for
git-credential-gopass,gopass-hibp,gopass-jsonapiandgopass-summon-providerwere removed from gopass and migrated into their own git repos. When the gopass_wrapper.sh script is executed, it tries to run 'gopass jsonapi listen' which is no longer a recognized command in gopass v1.12.0+.With the Gopass bridge Firefox extension installed, a window pops up when the user is prompted to log into a website:
and the Firefox Browser Console shows this error:
The
gopasscommand interprets "jsonapi" to be a secret and tries to lookup an entry for it which it does not find. The correct way to start the JSON API server is in newer versions of gopass is runninggopass-jsonapi listenfrom within the cloned gopass-jsonapi git repository. I have tested this change using gopass v1.12.7 and gopass-jsonapi v1.11.1 and verified the Gopass bridge extension is able to read secrets from my gopass secret store.Issues & PRs for reference: