Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go deps version upgrade #1569

Merged

Conversation

mridulji
Copy link
Contributor

What this PR does / Why we need it: This PR contains the changes in single PR that are being submitted by the dependabot in several PRs to upgrade the version of Go dependencies below:

  • golang.org/x/net v0.3.1-0.20221206200815-1e63c2f08a10 --> v0.7.0
  • golang.org/x/sys v0.3.0 --> v0.5.0
  • golang.org/x/text v0.5.0 --> v0.7.0

Which issue(s) this PR fixes:

Closes #1542
Closes #1543
Closes #1544
Closes #1545
Closes #1546
Closes #1547
Closes #1548
Closes #1549
Closes #1550
Closes #1551
Closes #1552
Closes #1553
Closes #1554
Closes #1555
Closes #1556
Closes #1557
Closes #1558
Closes #1559
Closes #1560
Closes #1561
Closes #1562
Closes #1563
Closes #1564
Closes #1565
Closes #1566
Closes #1567

Special notes for your reviewer:

@mridulji mridulji added the dependencies Pull requests that update a dependency file label Feb 27, 2023
@joeholley
Copy link
Collaborator

joeholley commented Feb 28, 2023

Error from the cloud build log seems to be pointing the finger at OpenPGP

Step 9/21 : RUN export CLOUD_SDK_REPO="cloud-sdk-stretch" &&     echo "deb http://packages.cloud.google.com/apt $CLOUD_SDK_REPO main" | tee -a /etc/apt/sources.list.d/google-cloud-sdk.list &&     curl https://packages.cloud.google.com/apt/doc/apt-key.gpg | apt-key add - &&     apt-get update -y && apt-get install google-cloud-sdk google-cloud-sdk-app-engine-go -y -qq &&     sudo apt-get update -y &&     sudo apt-get install -y google-cloud-sdk-gke-gcloud-auth-plugin
 ---> Running in 15d762b4768b
deb http://packages.cloud.google.com/apt cloud-sdk-stretch main
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).
gpg: no valid OpenPGP data found.
The command '/bin/sh -c export CLOUD_SDK_REPO="cloud-sdk-stretch" &&     echo "deb http://packages.cloud.google.com/apt $CLOUD_SDK_REPO main" | tee -a /etc/apt/sources.list.d/google-cloud-sdk.list &&     curl https://packages.cloud.google.com/apt/doc/apt-key.gpg | apt-key add - &&     apt-get update -y && apt-get install google-cloud-sdk google-cloud-sdk-app-engine-go -y -qq &&     sudo apt-get update -y &&     sudo apt-get install -y google-cloud-sdk-gke-gcloud-auth-plugin' returned a non-zero code: 2

@mridulji
Copy link
Contributor Author

Error from the cloud build log seems to be pointing the finger at OpenPGP

Yeah @joeholley, I am trying to build the image using Dockerfile.ci to fix it and test in local machine first.

@joeholley joeholley merged commit 98e7a02 into googleforgames:main Mar 2, 2023
@joeholley joeholley mentioned this pull request Aug 17, 2023
@joeholley joeholley mentioned this pull request Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants