Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will pin Open Match dependencies to predictable versions. This will allow for more reproducible builds since go get pulls code from repository HEAD, with the exception of aliased repos like gopkg.in.
After looking at go modules and vendoring it turns out the vendor/ directory is not touched if you build with go mod.
The recommended way is to just check in the go.mod and go.sum files to pin your dependencies to a known good checkout and download the dependencies one time.
The dependency output will be copied to $GOPATH/pkg/mod.
This change will set the minimum golang version for Open Match to 1.11. 1.12 is the latest version, 1.13 will turn go mod on by default.
For now you'll need to add this to your ~/.bashrc
export GO111MODULE=on