Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nodejs counters and lists #3726
Nodejs counters and lists #3726
Changes from 25 commits
e2d614d
276201d
7f2510c
ba75ad0
f7f3308
c98a9bc
1a45bc1
77e2f33
ab4e918
2f35140
f3a4992
b0a1666
c8979d8
6496474
4104682
6a56575
999c31d
2c5fc4b
a786e2a
795d0e7
e8075db
1f9ad51
68eeea4
e79c64a
e7d5c6c
935b47a
ca61c4b
441aa48
495abda
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By itself, this fails with error:
Once I run
~/agones/build$ SDK_FOLDER=node make test-sdk
it installs the dependencies successfully, and then the command~/agones/build$ make run-sdk-conformance-test-node
runs successfully. If there's not a quick way to check that the build script was run as part of therun-sdk-conformance-test-node
we should probably add a comment noting thatSDK_FOLDER=node make test-sdk
needs to be run first.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We would need to execute
npm install
in the sdk folder, e.g. in build-sdk-test.sh the minimum required isCould we add something like that here? I don't know enough about these makefiles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not worth modifying the make command, since the test gets build properly during CI / CD, so this only applies to local testing. I added in a suggested comment change above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made this to test with the local server but neither the counter or list can be found, so perhaps the structure is incorrect?
I started with
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you want the example to have the same counter and list as the local SDK Server? The sample local SDK server counters is "rooms" and lists is "players"
agones/pkg/sdkserver/localsdk.go
Lines 76 to 83 in 4b2910b
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, that's what I needed, so can perhaps remove this file and update the example
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shortening the delay as there as so many calls now