handle duplicate production names, with invalid PS chars, or too long (> 63 chars) #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93695af to
6dd6113
Compare
|
linking relevant fontmake issue #274 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch ensures that we never end up writing duplicate postscript glyph names in the post/CFF tables.
FontTools will crash if we set
TTFont.setGlyphOrder()to a list containing duplicate glyph names, so need to avoid this.Also, following AGL specification, we strip any characters that is not in the safe postscript character set
[A-Za-z0-9_.], e.g. like hyphens sometimes used in Glyphs.app.And we print a warning if a glyph name exceeds 63 characters in length (see adobe-type-tools/agl-specification#2).