Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow more SVG text in allowText option #294

Merged
merged 8 commits into from
May 17, 2023
Merged

Allow more SVG text in allowText option #294

merged 8 commits into from
May 17, 2023

Conversation

NightFurySL2001
Copy link
Contributor

SVG defineds 3 text element: text, tspan and textPath. Allows all 3 to be passthrough when allowText = True

@NightFurySL2001
Copy link
Contributor Author

Fixes #292

@anthrotype
Copy link
Member

Can you add a test in tests/svg_test.py maybe using the SVG from the issue report #292 ?
Add it somewhere here, name the file e.g. text-tspan-before.svg and save the expected result next to it, name it text-tspan-nano.svg like the others:

@NightFurySL2001
Copy link
Contributor Author

From what I see in 44192de, the push author used a new function instead of putting it in the mentioned position as picosvg should throw error when allowText = False.

Can @zond help a lil bit here?

@anthrotype
Copy link
Member

ok, yes you're right. Add a new test function or parametrize the one for allowText=True, thanks!

@anthrotype anthrotype closed this May 9, 2023
@anthrotype anthrotype reopened this May 9, 2023
@anthrotype
Copy link
Member

sorry I pushed the wrong button :)

tests/svg_test.py Outdated Show resolved Hide resolved
@NightFurySL2001
Copy link
Contributor Author

@anthrotype any updates?

@anthrotype anthrotype merged commit 52aff3a into googlefonts:main May 17, 2023
@anthrotype
Copy link
Member

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants