Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for providing a global bounding box. #290

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Added support for providing a global bounding box. #290

merged 1 commit into from
Feb 23, 2023

Conversation

zond
Copy link
Contributor

@zond zond commented Feb 23, 2023

  • Added some utility methods to the Rect class.
  • Added a bounding_box method to the SVG class.

anthrotype
anthrotype reviewed Feb 23, 2023
View reviewed changes
Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good overall, left some minor comments

@zond
Added support for providing a global bounding box.
c8e3f00 
- Added some utility methods to the Rect class.
- Added a bounding_box method to the SVG class.
@zond
Copy link
Contributor Author

zond commented Feb 23, 2023

Thanks, good advice!

@anthrotype anthrotype merged commit 84c649c into googlefonts:main Feb 23, 2023
@anthrotype
Copy link
Member

thanks!

@zond
Copy link
Contributor Author

zond commented Feb 23, 2023

🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype anthrotype left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zond @anthrotype